Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat(mr/view): show reviewers of the merge request #693

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

kousikmitra
Copy link
Contributor

Description
It enables mr view to show list of reviewers for a merge request

Related Issue

Delivers #692

How Has This Been Tested?
Added test case.

Locally tested with
glab mr view
glab mr view <id>
glab mr view <branch>

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Copy link
Collaborator

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! NIce work @kousikmitra

@zemzale
Copy link
Collaborator

zemzale commented Apr 28, 2021

The test case for commands/mr/view TestMRView/no_tty failed @kousikmitra

That needs to be fixed before this can be merged

@kousikmitra
Copy link
Contributor Author

can you approve the workflow please?

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #693 (738b978) into trunk (35e792f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #693      +/-   ##
==========================================
+ Coverage   59.95%   60.00%   +0.04%     
==========================================
  Files          90       90              
  Lines        6450     6458       +8     
==========================================
+ Hits         3867     3875       +8     
  Misses       2218     2218              
  Partials      365      365              
Impacted Files Coverage Δ
commands/mr/view/mr_view.go 76.82% <100.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e792f...738b978. Read the comment docs.

@zemzale
Copy link
Collaborator

zemzale commented Apr 28, 2021

All green now 🎉 . Thank you for working on this @kousikmitra

@zemzale zemzale merged commit c443358 into profclems:trunk Apr 28, 2021
@kousikmitra kousikmitra deleted the show-mr-reviewers branch April 28, 2021 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants