-
-
Notifications
You must be signed in to change notification settings - Fork 163
feat(repo): Create project from URL #709
feat(repo): Create project from URL #709
Conversation
This is gonna allow for creating projects using full URL which is gonna override the host URL too. Issue profclems#618
Codecov Report
@@ Coverage Diff @@
## trunk #709 +/- ##
==========================================
- Coverage 59.61% 59.48% -0.14%
==========================================
Files 90 90
Lines 6503 6518 +15
==========================================
Hits 3877 3877
- Misses 2254 2269 +15
Partials 372 372
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @zemzale.
I tested this and got a few issues
- This works fine when the argument provided is a URL (https://gitlab.com/profclems/test)
- Does not support ssh urls (e.g. git@gitlab.com:profclems/test.git)
- Does not support urls with
.git
prefix (https://gitlab.com/profclems/test.git) - It disregards the hostname and uses the default host
gitlab.com
Indeed these cases wont work. I will fix these issues, shouldn't be too hard, I just didn't have the chance to test against a private instance. |
I think it should be easier with this function in the Lines 117 to 183 in a17c562
|
This ensures supoport for - ssh urls - urls with .git prefix - respect hostname in url provided
@zemzale I just pushed a commit to fix the issues I listed |
Description
This is gonna allow for creating projects using full URL which is gonna
override the host URL too.
The command doesn't have unit tests and probably should be refactored, so I opened issue about that #708
Related Issue
Resolves #618
How Has This Been Tested?
Locally tested
Types of changes