Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

scriptability: Avoid truncating columns of tables/lists on non-TTYs #713

Merged
merged 2 commits into from
May 12, 2021

Conversation

profclems
Copy link
Owner

This is a hot fix to solve where glab still truncates lines with length longer that the specified column width on non-TTYs to improve scriptability

Resolves #706

@profclems profclems added Fix This fixes a bug or incorrect documentation needs: testing Some unit or manual testing is required labels May 12, 2021
profclems added 2 commits May 12, 2021 00:43
This is a hot fix to solve where glab still truncates lines with length longer that the specified column width on non-TTYs to improve scriptability

Resolves #706
@profclems profclems force-pushed the improve-scriptability branch from 0e651d9 to 0272873 Compare May 12, 2021 00:44
@pull-request-size pull-request-size bot added size/L and removed size/S labels May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #713 (0272873) into trunk (b3df43d) will increase coverage by 0.03%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #713      +/-   ##
==========================================
+ Coverage   59.50%   59.54%   +0.03%     
==========================================
  Files          90       90              
  Lines        6522     6535      +13     
==========================================
+ Hits         3881     3891      +10     
- Misses       2269     2272       +3     
  Partials      372      372              
Impacted Files Coverage Δ
pkg/tableprinter/table_printer.go 78.44% <85.18%> (-0.60%) ⬇️
cmd/glab/main.go 40.00% <100.00%> (+0.67%) ⬆️
commands/issue/list/issue_list.go 66.40% <100.00%> (-0.27%) ⬇️
commands/mr/list/mr_list.go 62.22% <100.00%> (ø)
commands/mr/mrutils/mrutils.go 66.01% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3df43d...0272873. Read the comment docs.

@profclems profclems merged commit 33f350c into trunk May 12, 2021
@profclems profclems deleted the improve-scriptability branch May 12, 2021 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fix This fixes a bug or incorrect documentation needs: testing Some unit or manual testing is required size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scriptability: avoiding ellipsize (...) of columns/lines
1 participant