This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Retry work #720
Merged
Retry work #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxice8
added
cmd: mr
Codecov Report
@@ Coverage Diff @@
## trunk #720 +/- ##
=======================================
Coverage 59.46% 59.46%
=======================================
Files 90 90
Lines 6535 6535
=======================================
Hits 3886 3886
Misses 2277 2277
Partials 372 372 Continue to review full report at Codecov.
|
|
we might want to use |
|
From https://docs.gitlab.com/ee/api/merge_requests.html#accept-mr If it has some conflicts and can not be merged - you receive a 406 and the error message ‘Branch cannot be merged’ |
…geable branch we do this retry so we can work around a rebase causing the branch to not be mergeable for a few seconds even though it has no conflicts. so instead of retrying for every possible error we use `RetryIf` to check if the error is the one expected and try again, otherwise we just exit with the error
…try multiple times
this is required because we need to verify the status code that is returned by GitLab
|
Reworked to have |
profclems
approved these changes
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This function uses the
retry.Optionsas documented in the system and fixes a segfaultRelated Issue
Resolves #719
How Has This Been Tested?
Merged stuff on
gitlab.alpinelinux.orgTypes of changes