Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Respect job ID when passing it to the trace command #767

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

cdloh
Copy link
Contributor

@cdloh cdloh commented Jun 14, 2021

Description

Reworked the RunTrace command so it takes a job instead of an SHA. It then respects that. View that passes in an SHA runs through RunTraceSha which then passes it the result onto RunTrace.

Related Issue

Resolves #766

How Has This Been Tested?

Thought I'd wait on feedback from this change first. If it's approved I'll take a punt at tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Signed-off-by: Callum Loh <callumloh@gmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #767 (399b13f) into trunk (2b76102) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #767   +/-   ##
=======================================
  Coverage   58.47%   58.47%           
=======================================
  Files          93       93           
  Lines        6681     6681           
=======================================
  Hits         3907     3907           
  Misses       2395     2395           
  Partials      379      379           
Impacted Files Coverage Δ
commands/ci/view/view.go 46.47% <0.00%> (ø)
commands/ci/trace/trace.go 58.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b76102...399b13f. Read the comment docs.

Copy link
Collaborator

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @cdloh

@profclems profclems merged commit fec203f into profclems:trunk Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Trace ID is ignored and latest job is always chosen
3 participants