This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
feat mr: remove prefix in ID of MR just like Issue #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change - improves consistency of APIs. - is copied from: https://github.com/profclems/glab/blob/0232a0c0791374ef5c1fa2072582a7127126b078/commands/issue/issueutils/utils.go#L106 - makes pipes easier - e.g., `glab mr list | fzf | grep -oE "^\S+" | glab mr view` - this is what atusy/ghf internally does Finishes profclems#789
Codecov Report
@@ Coverage Diff @@
## trunk #790 +/- ##
=======================================
Coverage 59.41% 59.41%
=======================================
Files 93 93
Lines 7341 7341
=======================================
Hits 4362 4362
Misses 2599 2599
Partials 380 380
Continue to review full report at Codecov.
|
zemzale
approved these changes
Jul 14, 2021
profclems
approved these changes
Jul 14, 2021
|
@profclems @zemzale Thank you, too!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change
glab/commands/issue/issueutils/utils.go
Line 106 in 0232a0c
glab mr list | fzf | grep -oE "^\S+" | glab mr viewDescription
This change adds support for a prefix in MR ID like below.
glab mr view \!1Related Issue
Resolves #789
How Has This Been Tested?
Run below on manjaro linux.
glab repo clone gitlab-org/gitlab-foss -- --depth 1 glab mr view "\!1"Screenshots (if appropriate):
Types of changes