This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
add support for mutual TLS authentication (client certificates) #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #794 +/- ##
=======================================
Coverage 59.41% 59.41%
=======================================
Files 93 93
Lines 7341 7341
=======================================
Hits 4362 4362
Misses 2599 2599
Partials 380 380 Continue to review full report at Codecov.
|
profclems
suggested changes
Jul 21, 2021
There was a problem hiding this comment.
Thanks for working on this @hexagonal-sun.
This looks good except that it's not gofmt'ed.
Add options that allow client certificate and key file paths to be set. This allows us to implement mutual TLS auth.
hexagonal-sun
force-pushed
the
client-certs
branch
from
036239b
to
6ac7680
Compare
|
@profclems Oops, sorry, I missed the |
profclems
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Great! Looks good...
Thanks fir working on this @hexagonal-sun
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements mutual TLS auth. Two new options have been created
client_certandclient_key. These allow the respective PEM files to be passed toglabwhich then allows us to use it for mutual TLS auth.(Apologies for any obvious errors here, I've never coded in
gobefore!)Related Issue
N/A
How Has This Been Tested?
I've ran this against my local gitlab instance and it works fine.
Screenshots (if appropriate):
Types of changes