Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix: allow token or stdin in non interactive shells #823

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

clwluvw
Copy link
Contributor

@clwluvw clwluvw commented Aug 14, 2021

Signed-off-by: Seena Fallah seenafallah@gmail.com

Description
Condition for checking login args in noninteractive mode was wrong and should check if one of stdin or token is provided is ok

Related Issue
Resolves #822

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Copy link
Collaborator

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @clwluvw. Thanks for the PR

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #823 (7b5dfba) into trunk (0456108) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #823   +/-   ##
=======================================
  Coverage   59.29%   59.29%           
=======================================
  Files          93       93           
  Lines        7353     7353           
=======================================
  Hits         4360     4360           
  Misses       2613     2613           
  Partials      380      380           
Impacted Files Coverage Δ
commands/auth/login/login.go 41.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0456108...7b5dfba. Read the comment docs.

@zemzale zemzale merged commit 664281e into profclems:trunk Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't auth login in non interactive mode
2 participants