Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lecturer Search #31

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Add lecturer Search #31

merged 3 commits into from
Nov 7, 2024

Conversation

DaymasS
Copy link
Contributor

@DaymasS DaymasS commented Nov 6, 2024

Изменения

Добавление поиска лектора по подстроке

Детали реализации

Поиск лектора по подстроке его имени

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@DaymasS DaymasS requested a review from Temmmmmo November 6, 2024 10:31
@DaymasS DaymasS self-assigned this Nov 6, 2024
@DaymasS DaymasS linked an issue Nov 6, 2024 that may be closed by this pull request
Добавить поиск преподавателей по ФИО #15
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py23387%35–36, 44
rating_api/models
   base.py55787%24–27, 45, 53, 74
rating_api/routes
   comment.py662858%28, 34–37, 85–108, 125–128, 142
   exc_handlers.py17288%26, 33
   lecturer.py881880%51, 111–135, 138, 140, 158, 166, 184, 190
rating_api/schemas
   base.py12467%6–9
TOTAL4106684% 

Summary

Tests Skipped Failures Errors Time
9 0 💤 0 ❌ 0 🔥 0.917s ⏱️

Temmmmmo
Temmmmmo reviewed Nov 7, 2024
View reviewed changes
rating_api/models/db.py Show resolved Hide resolved
rating_api/models/db.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

💩 Code linting failed, use black and isort to fix it.

@Temmmmmo Temmmmmo merged commit 0f67d7f into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Temmmmmo Temmmmmo Temmmmmo approved these changes

Assignees

@DaymasS DaymasS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Добавить поиск преподавателей по ФИО
2 participants
@DaymasS @Temmmmmo