Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lecturer total #36

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Fix lecturer total #36

merged 3 commits into from
Nov 10, 2024

Conversation

DaymasS
Copy link
Contributor

@DaymasS DaymasS commented Nov 10, 2024

Изменения

Тотал теперь возвращает общее число лекторов, найденных по фильтрам

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@DaymasS DaymasS requested a review from Temmmmmo November 10, 2024 00:30
@DaymasS DaymasS self-assigned this Nov 10, 2024
Copy link

💩 Code linting failed, use black and isort to fix it.

Copy link

github-actions bot commented Nov 10, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26581%17, 35–36, 44, 49
rating_api/models
   base.py552358%24–27, 35–38, 45, 53, 56, 58–59, 63–67, 72–77
   db.py581083%40–46, 50–54
rating_api/routes
   comment.py664039%28, 33–47, 55–58, 85–108, 125–128, 140–145
   exc_handlers.py20480%12, 26, 33, 40
   lecturer.py866327%31–33, 50–71, 104–146, 158–174, 184–195
rating_api/schemas
   models.py66198%34
TOTAL43015065% 

Summary

Tests Skipped Failures Errors Time
10 0 💤 10 ❌ 0 🔥 6.655s ⏱️

Copy link

💩 Code linting failed, use black and isort to fix it.

1 similar comment
Copy link

💩 Code linting failed, use black and isort to fix it.

Copy link

💩 Code linting failed, use black and isort to fix it.

@Temmmmmo Temmmmmo merged commit 90afb9c into main Nov 10, 2024
2 checks passed
DaymasS added a commit that referenced this pull request Nov 10, 2024
Merge pull request #36 from profcomff/fix-total-lecturer-num
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants