Skip to content

Conversation

@tomaszym
Copy link
Contributor

@tomaszym tomaszym commented Apr 30, 2021

Addresses #460 and maybe #445

I guess lettuce api evolved into into using objects and not a string as params and integration broke

The hard thing here would be to choose sane defaults – instead I've exposed the params which is a good thing anyway IMHO.

In the future this will need research and documentation because if I understood the docs correctly:

  • passing block 0 in redis blocks indefinitely (Duration.Zero or Duration.Inf or both 😆 ?)
  • I did not test/research what lettuce actually does when 0 passed

but for now I think it's better to patch it like this rather than wait

Links:

@gvolpe gvolpe requested a review from bplommer April 30, 2021 10:50
Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm definitely not familiar with this API but if it fixes the current issue I think it's already better :)

Any chances you can make a similar PR against the series/1.x branch? I don't think this can be cherry-picked because the code will be a bit different.

@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jun 29, 2021
@gvolpe
Copy link
Member

gvolpe commented Jun 29, 2021

Sorry this stayed open for so long, should've been merged long ago. If someone wants to pick up the work for the CE3 version, the issues will remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants