Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #460 and maybe #445
I guess lettuce api evolved into into using objects and not a string as params and integration broke
The hard thing here would be to choose sane defaults – instead I've exposed the params which is a good thing anyway IMHO.
In the future this will need research and documentation because if I understood the docs correctly:
block 0in redis blocks indefinitely (Duration.ZeroorDuration.Infor both 😆 ?)0passedbut for now I think it's better to patch it like this rather than wait
Links:
block 0in jedis xread with block=0 doesn't block redis/jedis#2277