Adding pooling support with keypool. #833
Conversation
|
@gvolpe and @decoursin can you please review? |
|
Sorry, I'm not going to be able to review, it's a little bit beyond my skill level to grasp the codebase in a reasonable time to give a qualified review. I do appreciate your potential contributions though. |
There was a problem hiding this comment.
Hey sorry for taking so long to review this, I've been away the last two months. Looking good in general, just left a few remarks.
Question for you: you mentioned you're using this approach in production, how is it working for you?
Thanks a lot for your contribution! 💟
modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala
Outdated
Show resolved
Hide resolved
modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala
Outdated
Show resolved
Hide resolved
modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala
Outdated
Show resolved
Hide resolved
modules/examples/src/main/scala/dev/profunktor/redis4cats/RedisPoolDemo.scala
Outdated
Show resolved
Hide resolved
modules/examples/src/main/scala/dev/profunktor/redis4cats/RedisPoolDemo.scala
Outdated
Show resolved
Hide resolved
modules/examples/src/main/scala/dev/profunktor/redis4cats/RedisPoolDemo.scala
Outdated
Show resolved
Hide resolved
|
@BusyByte do you need a help with fixes? |
….scala Co-authored-by: Gabriel Volpe <volpegabriel@gmail.com>
|
@gvolpe @yourzbuddha just getting back to this. kind of fell off my radar for a bit. I can see if I can get a chance to look at it today. |
|
@BusyByte I can assist. |
modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala
Outdated
Show resolved
Hide resolved
|
@gvolpe let me know if you need any additional changes from me |
|
@BusyByte thanks!
Yeah I've no idea either. Ideally, we should use MiMa, if anyone volunteers to do the work :) In the meantime, it is clarified in the README file:
|
|
@yourzbuddha thanks for offering to help, I had time today so just knocked it out |
|
Thanks guys :) |
| libraryDependencies ++= Seq( | ||
| Libraries.catsEffectKernel, | ||
| Libraries.redisClient, | ||
| Libraries.keyPool % Optional, |
5 participants
Closes: #822