Bug/subscribing to channel and pattern doubles messages in channel subscriber

[arturaz]

I have noticed that if you:

• subscribe to a channel "foo:bar"
• subscribe to a pattern "foo:*"

The messages sent to "foo:bar" will get delivered once to the "foo:*" stream and TWICE to the "foo:bar" stream.

This is a fix for that.

[yisraelU]

@arturaz does this occur with only one subscription to channel "foo:bar" ?
The method being changed is the decision to listen for patterns on a Channel Listener. According to your report, it would seem that all channel listeners (non patterned) would have both methods invoked when it receives a message .
This would seem to be a bug in Lettuce ?

[arturaz]

does this occur with only one subscription to channel "foo:bar" ?

No.

According to your report, it would seem that all channel listeners (non patterned) would have both methods invoked when it receives a message .

def message(pattern: K, channel: K, message: V): Unit = this.message(channel, message) is invoked when you get a message that matches a pattern that you subscribed to.

def message(channel: K, message: V): Unit is invoked when you get a message to a channel that you subscribed to.

Lettuce just notifies all of the listeners with all events that it receives, it has no idea what's the intent of the listener.

If you subscribed to a channel and a pattern matching the same channel, both methods will get invoked in the channelListener. You have patternListener for patterns, why would channelListener listen to BOTH patterns and channels?

This would seem to be a bug in Lettuce ?

This seems like a bug in redis4cats to me.

[arturaz]

Hi. Is there a reason why this does not get merged?

[yisraelU]

@arturaz Hey , sorry I've been out a bit the past few weeks.
Would you mind creating a reproducer that I can take a look at ?
TY

[arturaz]

Would you mind creating a reproducer that I can take a look at ?

WDYM? I wrote a test that fails if the code change is not there.