Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporte de um bug na lição Download de páginas Web com Python #2506

Closed
DanielAlvesLABDH opened this issue Mar 3, 2022 · 5 comments
Closed

Comments

@DanielAlvesLABDH
Copy link
Contributor

@joanacvp reportou um erro no código da lição Download de páginas Web com Python, quando em ambiente Windows. A utilização de "wb" é errada uma vez que estamos a lidar com texto. Deve ser usado "w". Vou corrigir no texto da lição já publicada.

@anisa-hawes
Copy link
Contributor

Hello @DanielAlvesLABDH. I'm happy to take care of Lesson Maintenance tasks, so feel free to assign me when something comes up!

The workflow we have implemented is detailed here: https://github.com/programminghistorian/jekyll/wiki/Lesson-Maintenance-Workflow

@anisa-hawes anisa-hawes self-assigned this Mar 3, 2022
@anisa-hawes
Copy link
Contributor

In this case, we'll need to check on the EN, ES and FR versions of the lesson too... This question of wb or w has come up numerous times, so I'm going to check back through some previous Issues to see what the best way forward is.

@DanielAlvesLABDH
Copy link
Contributor Author

Thanks for the help @anisa-hawes. On Windows changing the "wb" to "w" worked. But we will wait for your suggestion.

@anisa-hawes
Copy link
Contributor

anisa-hawes commented Mar 3, 2022

No problem. It looks as though that is the decision we came to in Issue #2448 and implemented in PR #2450.

I have just checked and w is already used in the EN, ES and FR lessons, so in this case a change in PT will make the code consistent across all:

/en/lessons/working-with-web-pages
/fr/lecons/telecharger-des-pages-web-avec-python
/es/lecciones/trabajar-con-paginas-web
/pt/licoes/download-paginas-web-python

I'll rebase your PR now, and it will be ready to merge.

@DanielAlvesLABDH
Copy link
Contributor Author

Great! Thanks @anisa-hawes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants