Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2448 #2450

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Issue 2448 #2450

merged 3 commits into from
Dec 22, 2021

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Dec 22, 2021

A reader has written to us to report an inconsistency in lesson 3 of our Python sequence, "Working with Text Files in Python".

I am updating the following lessons:

en/lessons/working-with-text-files
fr/lecons/travailler-avec-des-fichiers-texte
pt/licoes/trabalhando-ficheiros-texto-python

to ensure consistency across textual instructions and code blocks, and across all journals EN-ES-FR-PT.

Closes #2448

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

Change `wb parameter` to `w parameter` line 165 to make textual instruction consistent with code at line 122.
Change `le paramètre wb` to `le paramètre w` line 174 to make textual instruction consistent with code at line 125.
Change `O parâmetro wb` to `O parâmetro w` at line 116 (textual instruction) and at line 102 (code).
@anisa-hawes anisa-hawes merged commit d08b4ef into gh-pages Dec 22, 2021
@anisa-hawes anisa-hawes deleted the Issue-2448 branch December 22, 2021 15:10
@anisa-hawes
Copy link
Contributor Author

Thank you, @spapastamkou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify which Python parameter is required, w or wb?
2 participants