-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add avatar_alt text to lesson header images #1357
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I thought it could be useful to add avatar_alt in all already published FR
lessons and start doing it systematically in the ones that will follow.
So if I understand correctly, it is ok to only add
avatar_alt: [FR image title] in each lesson's yaml?
On confirmation (or correction:-)) I will work through a separate ticket.
… |
@spapastamkou yes, correct, just adding |
only did this for the 2 FR lessons that are on the branch; could add later for the remaining 2 once the branch is updated. |
@spapastamkou I just updated this branch based on the most current |
This comment has been minimized.
This comment has been minimized.
What is this sorcery? I do not understand what I have to do :-( |
@arojascastro - 397ffd1. For the files in the chunk you sign up for, you just need to add at the top as part of the YML metadata an avatar_alt category with text describing what the image for the lesson has in it. |
No worries, @arojascastro. That is why I assigned you a batch of avatar edits, since you are probably the one who edits more lessons. So, those images we place for each lesson (the little, square, B&W ones) need to have an alt text for screen readers to describe the image and, thus, make our site more accessible. You need to include 'avatar_alt' category in the YAML of the files I assigned you with a short description of the image. We are doing in on GitHub desktop to edit all lessons and then push them as a batch, rather than doing one by one online. |
Ok thank you both @jenniferisasi @walshbr - when is the deadline for this? :-S |
@arojascastro I don't think we set a deadline. |
I was looking for an image for an original lesson I am editing and I thought that perhaps from now on, for the next original lessons to be published in any language, we can define something like a small convention for the avatar_alt in yaml? For example, include the original title of the image (from the notice), source (the library or archive), and identifier. |
Are these three pears? So difficult to describe an image!
done my part... sorry and thanks |
I just went through and finished all the EN texts. The remaining work is listed below. (I've also rebased against our current branch so all available lessons should now be on this PR) |
@programminghistorian/french-team 👍
|
@programminghistorian/spanish-team
|
@programminghistorian/french-team and @programminghistorian/spanish-team We need just a few more |
to remaining lessons in ES
Hmm...is it giving errors because the FR tags are missing? I don't see anything wrong with the tags I just added. |
I added the avatar_alt text in four lessons out of five. |
@spapastamkou good catch! I put that into the wrong file. I'm pushing a change now. |
OK @spapastamkou I think this is ready - we just need the final French translation for comprendre-les-pages-web. I would propose a French translation, but I am not comfortable translating "ear trumpet" by myself 😂 Hopefully you have a more elegant term! |
adds avatar_alt text in remaining FR lesson
@mdlincoln did my best:) |
closes: #1324
To-do:
avatar_alt
fieldsavatar_alt
to required fields in travis checks