Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avatar_alt text to lesson header images #1357

Merged
merged 31 commits into from
Nov 18, 2019
Merged

Add avatar_alt text to lesson header images #1357

merged 31 commits into from
Nov 18, 2019

Conversation

mdlincoln
Copy link
Contributor

@mdlincoln mdlincoln commented Jun 27, 2019

closes: #1324

To-do:

  • determine if/how to do alt-text-translations
  • generate to-do list of lessons that need alt text
  • get all translations done
  • update editor guidelines and YAML template with avatar_alt fields
  • add avatar_alt to required fields in travis checks

@mdlincoln mdlincoln marked this pull request as ready for review August 30, 2019 14:46
@mdlincoln

This comment has been minimized.

@mdlincoln

This comment has been minimized.

@walshbr

This comment has been minimized.

@walshbr

This comment has been minimized.

@spapastamkou
Copy link
Contributor

spapastamkou commented Aug 30, 2019 via email

@mdlincoln
Copy link
Contributor Author

@spapastamkou yes, correct, just adding avatar_alt will be fine! Can you please add the commits to this branch?

@spapastamkou
Copy link
Contributor

only did this for the 2 FR lessons that are on the branch; could add later for the remaining 2 once the branch is updated.

@mdlincoln
Copy link
Contributor Author

@spapastamkou I just updated this branch based on the most current gh-pages code

@walshbr

This comment has been minimized.

@arojascastro
Copy link
Contributor

What is this sorcery? I do not understand what I have to do :-(

@walshbr
Copy link
Contributor

walshbr commented Sep 11, 2019

@arojascastro - 397ffd1. For the files in the chunk you sign up for, you just need to add at the top as part of the YML metadata an avatar_alt category with text describing what the image for the lesson has in it.

@jenniferisasi
Copy link
Contributor

jenniferisasi commented Sep 11, 2019

What is this sorcery? I do not understand what I have to do :-(

No worries, @arojascastro. That is why I assigned you a batch of avatar edits, since you are probably the one who edits more lessons. So, those images we place for each lesson (the little, square, B&W ones) need to have an alt text for screen readers to describe the image and, thus, make our site more accessible.

You need to include 'avatar_alt' category in the YAML of the files I assigned you with a short description of the image. We are doing in on GitHub desktop to edit all lessons and then push them as a batch, rather than doing one by one online.

@arojascastro
Copy link
Contributor

Ok thank you both @jenniferisasi @walshbr - when is the deadline for this? :-S

@walshbr
Copy link
Contributor

walshbr commented Sep 12, 2019

@arojascastro I don't think we set a deadline.

@spapastamkou
Copy link
Contributor

I was looking for an image for an original lesson I am editing and I thought that perhaps from now on, for the next original lessons to be published in any language, we can define something like a small convention for the avatar_alt in yaml? For example, include the original title of the image (from the notice), source (the library or archive), and identifier.
What do you think? If we agree, I can make a ticket to propose to the whole PH team. This would involve to make slight additions to the Editors guidelines, which I could take in charge.

@arojascastro
Copy link
Contributor

done my part... sorry and thanks

@mdlincoln
Copy link
Contributor Author

mdlincoln commented Nov 7, 2019

I just went through and finished all the EN texts. The remaining work is listed below. (I've also rebased against our current branch so all available lessons should now be on this PR)

@mdlincoln
Copy link
Contributor Author

mdlincoln commented Nov 7, 2019

@programminghistorian/french-team 👍

  • In /fr/lecons/analyse-corpus-antconc.md:

    • 'avatar_alt' is missing.
  • In /fr/lecons/comprendre-les-pages-web.md:

    • 'avatar_alt' is missing.
  • In /fr/lecons/introduction-a-la-stylometrie-avec-python.md:

    • 'avatar_alt' is missing.
  • In /fr/lecons/nettoyer-ses-donnees-avec-openrefine.md:

    • 'avatar_alt' is missing.
  • In /fr/lecons/travailler-avec-des-fichiers-texte.md:

    • 'avatar_alt' is missing.

@mdlincoln
Copy link
Contributor Author

mdlincoln commented Nov 7, 2019

@programminghistorian/spanish-team

  • In /es/lecciones/mineria-de-datos-en-internet-archive.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/normalizar-datos.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/palabras-clave-en-contexto-n-grams.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/poniendo-omeka-a-funcionar.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/preservar-datos-de-investigacion.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/procesamiento-basico-de-textos-en-r.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/reutilizacion-de-codigo-y-modularidad.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/salida-de-datos-como-archivo-html.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/salida-palabras-clave-contexto-ngrams.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/sparql-datos-abiertos-enlazados.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/topic-modeling-y-mallet.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/trabajar-con-archivos-de-texto.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/trabajar-con-paginas-web.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/transformacion-datos-xml-xsl.md:

    • 'avatar_alt' is missing.
  • In /es/lecciones/ver-archivos-html.md:

    • 'avatar_alt' is missing.

@mdlincoln
Copy link
Contributor Author

@programminghistorian/french-team and @programminghistorian/spanish-team We need just a few more avatar_alt additions on the lessons here, and then I will be ready to merge this PR!

to remaining lessons in ES
@jenniferisasi
Copy link
Contributor

jekyll 3.8.5 | Error: There were YAML errors.

Hmm...is it giving errors because the FR tags are missing? I don't see anything wrong with the tags I just added.

@spapastamkou
Copy link
Contributor

spapastamkou commented Nov 16, 2019

I added the avatar_alt text in four lessons out of five.
The remaining lesson corresponds to this original: https://programminghistorian.org/en/lessons/viewing-html-files I am not sure the avatar_alt text in the original ("A boy drawing on a tablet") corresponds to the image, am I mistaken in this? This is why I left it out and prefer to confirm here before adding a translation.
(And the build fails bcz the text is missing in the FR lesson)

@mdlincoln
Copy link
Contributor Author

@spapastamkou good catch! I put that into the wrong file. I'm pushing a change now.

@mdlincoln mdlincoln self-assigned this Nov 18, 2019
@mdlincoln
Copy link
Contributor Author

OK @spapastamkou I think this is ready - we just need the final French translation for comprendre-les-pages-web. I would propose a French translation, but I am not comfortable translating "ear trumpet" by myself 😂 Hopefully you have a more elegant term!

adds avatar_alt text in remaining FR lesson
@mdlincoln mdlincoln merged commit 0beaa9c into gh-pages Nov 18, 2019
@mdlincoln mdlincoln deleted the lesson-avatar branch November 18, 2019 18:54
@spapastamkou
Copy link
Contributor

@mdlincoln did my best:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alt-text descriptions for lesson galley images
6 participants