Issue 1460 transliterating #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python3, string objects str() are unicode aware by default. The u'' prefix before unicode strings is obsolete. Additionally, Python3 does not print escape sequences by default anymore, but literal unicode characters.
|
Thanks for this @frederik-elwert you've done a lot of work here. This is really an editorial matter, so I'm assigning this to our English Managing Editors to look at. @alsalin and @svmelton |
|
Thanks, all! @alsalin, could we walk through this together? |
|
@svmelton sorry for the delay - GH was tied to my Emory account, which was just deactivated. Happy to step through this with you |
svmelton
approved these changes
Oct 25, 2019
alsalin
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the transliterating lesson to use Python3. Since the lesson built heavily on Python2’s distinction between
str()andunicode()objects which is no longer relevant in Python3, I also had to change some substantial parts of the prose.Fixes #1471 and contributes to #1460.