-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1938 #1994
Issue 1938 #1994
Conversation
…mminghistorian/jekyll into issue-1938
Just in terms of a timeline @ZoeLeBlanc, I'm hoping to have a placement student to test some lessons in May. Are we likely to have this live in time, or will we have to keep track on a spreadsheet or something else in the meantime? |
We should have it available pretty soon @acrymble. I think the technical team is about done on our end so going to make this PR live and request translation from various teams! |
Would members of @programminghistorian/spanish-team @programminghistorian/french-team @programminghistorian/portuguese-team be able to translate some snippets for this PR? I'm happy to add in the data or have people merge into this branch, but I need translations of the words You can see the snippets fields below:
Thanks! |
Hello!
For portuguese we can write:
*For lesson-testers*
pt: Testado por
*For lesson-date*
pt: ultimo teste or testado em *or* testado
Ricardo M Pimenta
Em qua., 24 de mar. de 2021 08:59, Zoe LeBlanc ***@***.***>
escreveu:
… Would members of @programminghistorian/spanish-team
<https://github.com/orgs/programminghistorian/teams/spanish-team>
@programminghistorian/french-team
<https://github.com/orgs/programminghistorian/teams/french-team>
@programminghistorian/portuguese-team
<https://github.com/orgs/programminghistorian/teams/portuguese-team> be
able to translate some snippets for this PR?
I'm happy to add in the data or have people merge into this branch, but I
need translations of the words tested by and either last tested or tested
on (which ever makes more sense to you) for this PR.
You can see the snippets fields below:
lesson-testers:
en: tested by
es:
fr:
pt:
tested-date:
en: tested
es:
fr:
pt:
Thanks!
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#1994 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AITPD3T2WDKQQHAXE37AKCDTFHH3LANCNFSM4WRBOTNQ>
.
|
Thanks so much @pymentha 🙏🏽 ! Just merged in your translations 🎉 |
@programminghistorian/spanish-team: Which translation do you think works best in this case? testeado por y último test, probado por y última prueba, ¿otra? |
@programminghistorian/spanish-team would anyone have time to add a translation to this branch so we could merge this in? Thanks 🙏🏽 ! |
@ZoeLeBlanc, done! |
Thanks so much @rivaquiroga ! Just one final issue for the @programminghistorian/spanish-team to chime in on. There's a breaking link in the lesson |
Hi @ZoeLeBlanc. That lesson is retired, so no need to maintain it, but also makes me wonder (cos I don't remember) if it is necessary that the build runs inside the retired lessons to look for broken links? |
This PR is a first attempt at closing #1938. It adds two fields to lessons.html and snippets.yaml, a
tested_date
andlesson-tester
so that we can begin to record testing of lessons.The names of lesson testers will appear next to reviewers, editors, translators, etc... whereas the lesson tested date will appear below next to published, modified, translated date, etc...
This setup assumes that we will only record the most recent tested date, but that we will record all previous lesson testers. The rationale is that though we could include all testing dates that info is less relevant (we mostly want to know if it's stale or not) and we want to give credit to all testers. So therefore list of names, but only one date to try and minimize user entered data errors.
Prior to merging this PR, we'll need to update lesson guidelines. Also open to discussing additional fields or formats!
Checklist
Closes #ISSUENUMBER
to the description aboveIf you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.