Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipp middle band #2073

Merged
merged 9 commits into from
Mar 20, 2021
Merged

Ipp middle band #2073

merged 9 commits into from
Mar 20, 2021

Conversation

acrymble
Copy link

@acrymble acrymble commented Mar 19, 2021

Closes #1988 - Middle IPP band

Adds a £400 rate for middle income countries to the EN/ES/FR pages.

The PT pages need a total redoing so I will update them all at once when we've had a chance.

I need my language checked on FR and ES:

  • Paises de alto ingreso | Paises de ingreso medio | países AOD
  • Pays à revenu supérieur | Pays à revenu intermédiaire | Tarifs échelonnés pour les pays éligibles à l'APD

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

rivaquiroga
rivaquiroga previously approved these changes Mar 19, 2021
Copy link
Contributor

@spapastamkou spapastamkou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbers above thousand need to be written without comma and adding a space instead: 1,200 => 1 200. I will make the changes.

@spapastamkou
Copy link
Contributor

I followed the official terms for categorizing countries according to income as per this list of the OECD. Please check if you are happy with the form @acrymble, I may have changed the link placement.

@acrymble acrymble merged commit 0a1ad27 into gh-pages Mar 20, 2021
@acrymble acrymble deleted the ippMiddleBand branch March 20, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middle IPP band criteria
4 participants