Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparql link 404 #290

Merged
merged 3 commits into from
Sep 14, 2016
Merged

Sparql link 404 #290

merged 3 commits into from
Sep 14, 2016

Conversation

mdlincoln
Copy link
Contributor

Addresses #289

  1. Replaces a broken link to a SPARQL tutorial in the "Further Reading" section with a link to the W3C overview of SPARQL (which is actually a better place for more in-depth study, anyway!)
  2. Adds a note to the "Linking multiple SPARQL endpoints" section explaining that the Europeana endpoint is down as of 2016-09-12 until further notice (pending new info from the folks at Europeana Labs)

@wcaleb I bolded the advisory note, but if there's some other class baked into the PH CSS that would be better to use for this deprecation note, please let me know / edit the PR

@wcaleb
Copy link
Contributor

wcaleb commented Sep 13, 2016

There is a deprecated: true flag that produces this message at the top, but I don't know if it would be appropriate in this case. I think on some other recent lessons @acrymble has written a more descriptive message like the one that you have in this PR. Thoughts?

@mdlincoln
Copy link
Contributor Author

Agreed, I would not use the deprecated flag because it is inappropriate. If you're fine with just a boldface message at the start of the affected section, then we're all set. I suppose you could make it red or something, too?

@wcaleb wcaleb merged commit eb060ec into programminghistorian:gh-pages Sep 14, 2016
@mdlincoln mdlincoln deleted the sparql_link_404 branch September 14, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants