Update miditime import #568
Conversation
The miditime import in the example didn't work for me, I had to switch it to this version. I used `pip install` and got `miditime==1.1.3`. (The project documentation shows the old import, but that doesn't work.) I thought it might be worth updating, because if people aren't familiar with Python they may not be able to figure it out. You might want to add something about the version of miditime or document the older syntax also, but I don't know where that should go.
|
Thanks @rlskoeser! Pinging @shawngraham here – thoughts Shawn? |
|
(fyi the build break is due to #569, and not due to anything in this PR) |
|
just saw this. Thank you @rlskoeser . I'm rather swamped at the moment, but I guess I'd better add the info re versions and so on. Appreciate the headsup. |
|
Do you have any thoughts on merging this, @shawngraham? |
|
@ianmilligan1 i'm not sure what you want to merge? Life has intervened, and I won't be able to give this any serious attention for the next few weeks unfortunately |
|
There's just one line of changed code in the pull request. See screenshot or click on "Files Changed" up above. Is this OK to merge in? |
|
@ianmilligan1 it's possible that change won't work in older versions of miditime, I'm not sure when it changed. if it would help, I could update with a comment to that effect with a note that people should try the older import if the new one doesn't work? |
|
Sure, why don't you do that, and then we can see if @shawngraham is happy with the note? |
|
@ianmilligan1 @shawngraham I added a brief comment in the python sample code with a note about the old syntax. (Sorry I didn't just include that the first time.) |
|
Great, thanks so much @rlskoeser! Let me know @shawngraham, happy to merge if you are fine with this minor tweak. |
|
I'm ok with it. Thanks @rlskoeser ! much appreciated |
|
Great, thanks all. |
The miditime import in the example didn't work for me, I had to switch it to this version. I used
pip installand gotmiditime==1.1.3. (The project documentation shows the old import, but that doesn't work.)I thought it might be worth updating, because if people aren't familiar with Python they may not be able to figure it out. You might want to add something about the version of miditime or document the older syntax also, but I don't know where that should go.
NOTICE: Are you attempting to submit a lesson to the Programming Historian? We no longer accept lesson submissions by pull request to this repository. Please consult our guidelines for submitting a lesson for further instructions.
If your pull request instead concerns some issue with the formatting or functioning of our site, or some error in an existing lesson, please see our technical contribution guidelines: https://github.com/programminghistorian/jekyll/wiki/Making-technical-contributions