Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lesson template to Author Guidelines #991 #998

Merged
merged 8 commits into from
Sep 26, 2018
Merged

New lesson template to Author Guidelines #991 #998

merged 8 commits into from
Sep 26, 2018

Conversation

acrymble
Copy link

Closes #991 - New Lesson Template.

I have added the "new lesson template" markdown template to the English version of the Author Guidelines. I have also removed a few sections of that file that were redundant after the new template was inserted (how to write endnotes, how to add the metadata block). Finally, I moved a few sections around so that all sections about markdown were together, and information on writing sustainably and globally was after rather than in the middle.

I have NOT made changes to the Spanish file (which is actually different anyway because of information on translation). Can someone on the Spanish team please decide if they would like to update the Spanish guidelines as well?

@acrymble
Copy link
Author

This has been waiting a few weeks for comment. I suspect that means the Spanish Team doesn't want to pursue this idea. If that's the case, can someone let me know? @mariajoafana @vgayolrs @jamotilla @jenniferisasi

@vgayolrs
Copy link
Contributor

Hi @acrymble . As far as I know, there has not been a discussion about it in the Spanish team. Give me a few days and I ask to reach a consensus. At least I think it's important.

@mariajoafana
Copy link
Contributor

I think is important as well. If you all agree I can take care of translating the submission form and add it to the Spanish language guidelines, for new submissions.

@jenniferisasi
Copy link
Contributor

Hi!
I agree it would help us a lot. @mariajoafana, I can take care of doing the changes on the guidelines to follow what @acrymble has done in English after you translate the form - that way we divide the work.

@vgayolrs
Copy link
Contributor

Excellent @jenniferisasi ! Tell us if you need help or support at any point.

mariajoafana
mariajoafana previously approved these changes Sep 23, 2018
Copy link
Contributor

@mariajoafana mariajoafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create a pull request for the Spanis translation once is ready

@mariajoafana
Copy link
Contributor

Formulario.Consulta.Lección.txt
Traduje el formulario al español. @jenniferisasi Please take a look at it before adding it to the author guidelines. @acrymble Where in the author guidelines is the form to be found?

@acrymble
Copy link
Author

@mariajoafana it replaced the "add metadata" section. You can see all the changes here (but I realise that it's difficult to see like that): https://github.com/programminghistorian/jekyll/pull/998/files

@acrymble
Copy link
Author

@mariajoafana would it be easier if I merged this pull request so you could see the clean version of the new guidelines?

@mariajoafana
Copy link
Contributor

@acrymble Yes, that'll be easier

@acrymble
Copy link
Author

Ok. I had to make a minor update to resolve a conflict with the existing website. @mariajoafana can you re-review, and then just merge it yourself? Then we can open a new ticket for the Spanish one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants