-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizing data with R and ggplot2 #354
Comments
Very belated but excited to get this ticket setup and the lesson formatted correctly for Visualizing Data with R and ggplot2 🎉 @nabsiddiqui would you mind giving me Igor Sosa Mayor's Github handle, I couldn't find it myself. Thanks! Also if you would both take a quick look over the lesson and let me know if there's anything you want to update before I do my initial edit pass since this was submitted some time ago. I did notice already that there's a typo at the end of paragraph 18 where a word is cut in half so things like that might have been missed on the initial submission. Once you let me know it's good to go, I'll do my first pass and send you my edits. Then once those are done, I'll solicit reviewers, and hopefully we can get this lesson peer reviewed and published by the summer! Let me know if you have any questions and thank you for your patience and submission!! |
@ZoeLeBlanc, @nabsiddiqui, I was taking a look to this lesson because it's about a topic I'm interested in, and I realized that on ¶90 (Additional Resource) it points to an old link for the ggplot extensions website. I would suggest to change it as soon as possible for https://exts.ggplot2.tidyverse.org/gallery/, as the old one is NSFW. |
@rivaquiroga Well that was unexpected...I have just removed the additional resources. They aren't really necessary for the tutorial and the other links that are posted should be fine. @ZoeLeBlanc I'll reread it tomorrow and let you know. Igor's Github is @rogorido. Also link up top is not working. |
@ZoeLeBlanc Went ahead and just read it and fixed up some small errors. Should be good to go. I also removed all links to the offending page. |
Thanks @nabsiddiqui ! Also thanks for catching the link above and helping me find @rogorido's handle! I'll try and have my comments posted here no longer than a week from today (so by Monday March 29). Let me know if anything comes up before then or if you have any questions, and looking forward to digging in to this lesson 😊 |
Alrighty! Mea culpa for the big delay but here's my initial editorial notes below @nabsiddiqui & @rogorido . I realize it's always tough to get feedback so please feel free to take as much time you need to decide what you want to incorporate and what you don't from my feedback. All of it is in essence optional, but I would appreciate that if you aren't going to address an issue that you offer some rationale for your choice. I'm also happy to chat about the feedback and help your brainstorm how to incorporate it into the lesson. The big thing I'll need to know is when you plan to get through this feedback (again take as much as you need), so that I can start soliciting reviewers. P1
P6
P7
P8
General comment. I'm not sure defining all these terms here is the best way to introduce these concepts. In particular, I feel like you jumped a bit ahead without discussing why someone would even want to create a grammar of graphics. I wonder if a simpler explanation about the concept of creating a 'statistical graph' that mentions these terms might help readers understand what the terms mean in context. P10
P12
P15
P16
P17
P18
P19
P20
P25
P26
Generally very confused about what P28
P31
P33
P34
P37
P40
P41
P43
P44
P49
P50
P54
P62
P63
P64
P65
P66
P67
P68
P71
P73
P75
P77
P81
P85
P86
It would be helpful to conclude the lesson with some assessment of how this approach helped readers understand something about sister cities. Otherwise the lesson ends very abruptly. I realize this is a lot of points, but most of them are small tweaks. Again feel free to reach out if you have additional questions or if anything is unclear, and thank you again for your patience. Excited to moving towards getting this out to reviewers and then published 🎉 |
Greetings @nabsiddiqui & @rogorido! Just wanted to ping you to see if you had any questions for me about my feedback or sense of your timeline for these revisions? NO pressure! Seriously took me forever to get to this, so don't want to rush you at all. Just wanted to make sure that you knew I was still committed to helping get your lesson published, and that I'm happy to help clarify any of the above comments 😊 |
Hey @ZoeLeBlanc. I am still working on some of the revisions. It shouldn't be too much longer, but it is a busy summer and Fall. I will let you know if I need any additional help. |
Hello all, Please note that this lesson's .md file has been moved to a new location within our Submissions Repository. It is now found here: https://github.com/programminghistorian/ph-submissions/tree/gh-pages/en/drafts/originals A consequence is that this lesson's preview link has changed. It is now: http://programminghistorian.github.io/ph-submissions/en/drafts/originals/visualizing-data-with-r-and-ggplot2 Please let me know if you encounter any difficulties or have any questions. Very best, |
@ZoeLeBlanc Took a long time to get back to this, but we have completed the revisions based on initial feedback. Let me know next steps and timeline, etc. @anisa-hawes I upload new images for the tutorial. Right now, they are linked with a full source URL to the new images. I didn't know how the backend works enough to know how to do it in Markdown. Can you look at the links to the images and let me know how to fix them? |
Hello @nabsiddiqui. Yes, I can help. The format required is:
I can see that you've used the title tag I also note that, at the moment, your alt text and titles/captions match. Ideally the caption is a very concise line of text to number and identify the image, so that it can be understood within the context of the lesson content. Meanwhile, the alt text would explain visual information in the image for screen reader users. Do you have time to adjust these? |
@anisa-hawes Yes, I will adjust these soon. |
@anisa-hawes Should be good to go now. |
Thank you, @nabsiddiqui. Alt text looks good, and the images are displaying correctly in the preview. |
Thank you. @ZoeLeBlanc I think it should be good for sending to reviewers now. |
Hello @nabsiddiqui. Zoe is feeling unwell, so please be patient as you wait to hear back about the revisions you've submitted. |
No worries. We aren’t in any rush. Just wanted to make sure we got everything requested on our end. |
@nabsiddiqui just to update you, @ZoeLeBlanc should be getting to this in the coming month |
Sounds good. Thanks. |
@ZoeLeBlanc what's the status on editing this lesson? |
Sorry for the slow reply @hawc2 ! Unfortunately, realistically I won't be able to get to this until May, so feel free to reassign it to a different editor if you would prefer the lesson move faster. I'm just a bit overcommitted at the moment so apologies for needing more time! |
Hey @ZoeLeBlanc, if you can pick up this lesson in May, then let's keep you on as editor. Hopefully we can move this lesson forward and publish before end of the year. If you don't think it's feasible for you to handle other PH responsibilities and continue to work as an Editor on a lesson like this, though, please let me know and I'll look into alternatives. |
@ZoeLeBlanc will you be able to edit this lesson? I am thinking we should ask @nabsiddiqui to revise and resubmit this lesson in the fall for our new submission period. Perhaps you can give him guidelines now for that revision before he submits in the fall? |
@hawc2 sorry for being slow and that sounds perfect! I'll take a look and try to get any notes back in the next two weeks @nabsiddiqui and then come Fall we can work on finalizing reviewers. Thanks for being so understanding and patient! |
I think you should reject this on time elapsed @hawc2 |
Thanks @acrymble. I've discussed this with @anisa-hawes and @nabsiddiqui and we are planning to invite the authors of this submission @nabsiddiqui and @rogorido to revise and resubmit this lesson. We shouldn't 'reject' this lesson outright, as the delay in its review is our fault, for which I apologize. I agree that we should close this ticket though, and I'm doing that with this comment. The English edition of Programming Historian is currently starting a new submission process, where we will post a CFP this fall, and accept a number of lessons to be edited and reviewed next year. I would highly encourage the authors to make some revisions to this lesson this fall, resubmit, and hopefully this will be brought into the publishing pipeline more efficiently next year. @nabsiddiqui and @rogorido if you have any concerns or questions about this plan, please email me, the Managing Editor for the English journal, at english@programminghistorian.org. I would also be happy to review a draft of your lesson and give feedback via email this fall if that is helpful. |
The Programming Historian has received the following tutorial on Visualizing data with R and ggplot2 by @nabsiddiqui & @rogorido. This lesson is now under review and can be read at:
http://programminghistorian.github.io/ph-submissions/en/drafts/originals/visualizing-data-with-r-and-ggplot2
Please feel free to use the line numbers provided on the preview if that helps with anchoring your comments, although you can structure your review as you see fit.
I will act as editor for the review process. My role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum. I have already read through the lesson and provided feedback, to which the author has responded.
Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. I will make an announcement on this thread when that has occurred.
I will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me.
Our dedicated Ombudsperson is (Ian Milligan - http://programminghistorian.org/en/project-team). Please feel free to contact him at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudsperson will have no impact on the outcome of any peer review.
Anti-Harassment Policy
This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.
[Permission to Publish]
The editor must also ensure that the author or translator post the following statement to the Submission ticket.
The text was updated successfully, but these errors were encountered: