Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: added code so decode always returns accuracyBonus even if 100k #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielJDufour
Copy link
Collaborator

This should fix #29 .

I haven't tested toPoint on 100k MGRS strings, but my quick read through the code makes me thin this might change the result of toPoint for a 100k from the bottom left to the centroid. The centroid is now correct, but I want to make sure this change in functionality and results has a test case for it before requesting a new version is published.

If you want to use this functionality now, you can copy the mgrs.js file in the root directory. (I haven't run build, so dist/mgrs.js is the old version that is on NPM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inverse does not return bbox for 100km grid zone
1 participant