add implementation details for configuration device plugin #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnson Shih <jshih@microsoft.com>
johnsonshih
requested review from
kate-goldenring,
bfjelds,
romoh,
jiria and
edrickwong
as code owners
This was referenced Jul 10, 2023
diconico07
approved these changes
Jul 17, 2023
| The `ConfiguratinDevicePlugin` defines the behavior of the configuration-level resources, combined with `DevicePluginService`, it forms a device plugin that advertises the configuration-level resources to the kubelet. | ||
|
|
||
| Similar to the Agent creates a `DevicePluginService` with `InstanceDevicePlugin` behavior for each discovered Instance. The Agent creates a `DevicePluginService` with `ConfigurationDevicePlugin` behavior for each Configuration when the Configuration is applied to the cluster. All `DevicePluginService` share the same structure that has `list_and_watch` and `allocate` for kubelet to call. The actual behavior of `list_and_watch` and `allocate` is defined in `ConfigurationDevicePlugin` and `InstanceDevicePlugin` for Configuration and Instance respectively. | ||
| The CL and IL device plugin need to coordinate to sync up available resources so when a resource is claimed by CL (or IL) device plugin, the other device plugin is notified and re-caculate the available resources for itself. The `list_and_watch_message_sender` in `DevicePluginService` is used for notifying available resource change within a device plugin. For notifying resouce change across device plugins, a copy of `list_and_watch_message_sender` for each `DevicePluginService` are saved in `InstanceConfig`, where `usage_update_message_sender` holds the message sender of CL device plugin and IL device plugin's `list_and_watch_message_sender` is saved in each instance's `InstanceInfo`. |
There was a problem hiding this comment.
Suggested change
| The CL and IL device plugin need to coordinate to sync up available resources so when a resource is claimed by CL (or IL) device plugin, the other device plugin is notified and re-caculate the available resources for itself. The `list_and_watch_message_sender` in `DevicePluginService` is used for notifying available resource change within a device plugin. For notifying resouce change across device plugins, a copy of `list_and_watch_message_sender` for each `DevicePluginService` are saved in `InstanceConfig`, where `usage_update_message_sender` holds the message sender of CL device plugin and IL device plugin's `list_and_watch_message_sender` is saved in each instance's `InstanceInfo`. | |
| The CL and IL device plugin need to coordinate to sync up available resources so when a resource is claimed by CL (or IL) device plugin, the other device plugin is notified and re-caculate the available resources for itself. The `list_and_watch_message_sender` in `DevicePluginService` is used for notifying available resource change within a device plugin. For notifying resource change across device plugins, a copy of `list_and_watch_message_sender` for each `DevicePluginService` are saved in `InstanceConfig`, where `usage_update_message_sender` holds the message sender of CL device plugin and IL device plugin's `list_and_watch_message_sender` is saved in each instance's `InstanceInfo`. |
|
|
||
| The `ConfiguratinDevicePlugin` defines the behavior of the configuration-level resources, combined with `DevicePluginService`, it forms a device plugin that advertises the configuration-level resources to the kubelet. | ||
|
|
||
| Similar to the Agent creates a `DevicePluginService` with `InstanceDevicePlugin` behavior for each discovered Instance. The Agent creates a `DevicePluginService` with `ConfigurationDevicePlugin` behavior for each Configuration when the Configuration is applied to the cluster. All `DevicePluginService` share the same structure that has `list_and_watch` and `allocate` for kubelet to call. The actual behavior of `list_and_watch` and `allocate` is defined in `ConfigurationDevicePlugin` and `InstanceDevicePlugin` for Configuration and Instance respectively. |
There was a problem hiding this comment.
nit: This line is a bit hard to read/understand
| `akri-onvif-8120fe-1`, and `akri-onvif-a19705-0` to free. The Configuration device plugin then reduce the device availability to "0", "1" and "3". | ||
| If kubelet retry to claim "0" and "1", the Configuration device plugin will allow it by mapping "0" to `akri-onvif-8120fe-0` or `akri-onvif-8120fe-1`, "1" to `akri-onvif-a19705-0`. | ||
|
|
||
| The Configuration device plugin reports "0", "1", ... as virtual device ids in `list_and_watch` and determines the actual device slot to be used when `allocate` is called. The algorithm to map virtual device ids to actul device slot works on the allocation requests on a per-container basis that: |
There was a problem hiding this comment.
Suggested change
| The Configuration device plugin reports "0", "1", ... as virtual device ids in `list_and_watch` and determines the actual device slot to be used when `allocate` is called. The algorithm to map virtual device ids to actul device slot works on the allocation requests on a per-container basis that: | |
| The Configuration device plugin reports "0", "1", ... as virtual device ids in `list_and_watch` and determines the actual device slot to be used when `allocate` is called. The algorithm to map virtual device ids to actual device slot works on the allocation requests on a per-container basis that: |
…ConfigurationDevicePlugin/InstanceDevicePlugin Signed-off-by: Johnson Shih <jshih@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation details for Configuration level resource support, the PR project-akri/akri#627 implements the design