Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuring device mount permissions in udev Discovery Handler #726

Closed
kate-goldenring opened this issue Nov 26, 2024 · 0 comments · Fixed by #737
Closed

Enable configuring device mount permissions in udev Discovery Handler #726

kate-goldenring opened this issue Nov 26, 2024 · 0 comments · Fixed by #737
Assignees
Labels
good first issue Good for newcomers

Comments

@kate-goldenring
Copy link
Contributor

USB devices are mounted by Akri using the device plugin interface. Here is where that is done. By default, read/write/modify permissions are set by the udev discovery handler. These permissions should be configurable for the discovery handler for a Configuration. We'd need to add a new field to the discoveryDetails of the discovery handler here: https://github.com/kate-goldenring/akri/blob/733fae50c1dae6ec8351c92a5e6ba9695ba1f7e1/discovery-handlers/udev/src/discovery_handler.rs#L28-L29

@kate-goldenring kate-goldenring added the good first issue Good for newcomers label Nov 26, 2024
@github-project-automation github-project-automation bot moved this to Triage needed in Akri Roadmap Nov 26, 2024
@yujinkim-msft yujinkim-msft moved this from Triage needed to Backlog in Akri Roadmap Jan 14, 2025
bindsi added a commit to bindsi/akri that referenced this issue Jan 17, 2025
project-akri#726

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
@bindsi bindsi moved this from Backlog to In progress in Akri Roadmap Jan 17, 2025
bindsi added a commit to bindsi/akri that referenced this issue Jan 22, 2025
project-akri#726

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
yujinkim-msft pushed a commit that referenced this issue Jan 22, 2025
#726 (#737)

* added configuring of device mount permissions in udev discovery handler #726

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* incremented version

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* formatting

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* fixed version

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* updated helm chart version

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* updated rust version

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* updated rust version to 1.84

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* fixed default for permissions

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* added default func for permissions

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* updated rust version to 1.81

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* Update discovery-handlers/udev/src/discovery_handler.rs

Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* added unit test and added dependencies

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* test for permissions

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* removed unused var

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* restructured test

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* fixed test

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* added default permissions for lint files

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* signoff Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

* removed panic

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>

---------

Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com>
@github-project-automation github-project-automation bot moved this from In progress to Done in Akri Roadmap Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants