-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info about openssl, pkg-config deps #339
Conversation
- Without previous installation of `openssl-dev`, `pkg-config`, `cargo install cargo-generate` will fail. - Potential solution is to install the respective dependencies beforehand Tested On: Windows10 Pro + WSL2 (Ubuntu-20.04 LTS) + rustc > v1.51 Possible Solution found on: sfackler/rust-openssl#951 Signed-off-by: Shan Desai <shantanoo.desai@gmail.com>
Hi Shan! Thanks for finding this. Would it make sense to use the |
@kate-goldenring fair point. From a trade-off perspective Better approach would be to give the reader the choice, either dependencies installation or enable the |
@shantanoo-desai, is there a way to point out to their documentation so that they have the option, and if their dependencies change we don't need to update our docs? |
I was trying to make some sense of the Akri MQTT integration and it turns out The Eclipse Paho Group which is responsible for providing MQTT clients in all programming languages do use the I am not sure why the rust opc-ua client doesn't have such bindings for SSL Certificates. |
Which rust opc ua client are you referring to? Akri's OPC UA discovery handler or a specific crate? For this PR, i think it would be best to do remove How does that sound? |
The So for this PR it should look something like the following: -> NOTE: `cargo-generate` depends on `openssl-dev` and `pkg-config` and need to be installed beforehand
-
-__GNU/Linux__:
-
-```sh
-apt install -y openssl-dev pkg-config
-```
-
-__macOS__:
+Install [`cargo-generate`](https://github.com/cargo-generate/cargo-generate#installation) and specify the name of the project with the `--name` parameter. |
Akri's OPC UA discovery handler is simply querying opc ua server's discovery endpoints (which do not require authentication). The client is not creating credentials for itself which may be why no bindings for ssl certs are required. |
- Reason: `cargo install cargo-generate` provides `--features` flag to enable SSL binding which can add dependencies and remove the `openssl-dev` and `pkg-config` standalone installations. - Approach: Give user the choice to either install these deps accordingly by pointing to the Installtion Instruction for `cargo-generate` Signed-off-by: Shan Desai <shantanoo.desai@gmail.com>
Signed-off-by: Shan Desai <shantanoo.desai@gmail.com>
@shantanoo-desai can you add your mqtt proposal from commit 00d0393 to a different PR? |
openssl-dev
,pkg-config
,cargo install cargo-generate
will fail.Tested On: Windows10 Pro + WSL2 (Ubuntu-20.04 LTS) + rustc > v1.51
Possible Solution found on: sfackler/rust-openssl#951
Signed-off-by: Shan Desai shantanoo.desai@gmail.com
What this PR does / why we need it:
Additional Information in Documentation for creating a custom discovery handler.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)