-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAME VERSION] Workflow to mark inactive issues/PRs as stale and eventually close them #363
Conversation
stale-pr-message: > | ||
PR has been automatically marked as stale due to inactivity for 45 days. Update the PR to remove label, otherwise it will be automatically closed." | ||
exempt-issue-labels: keep-alive | ||
token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to double check ... does {secrets.GHTOKEN} have any issue with PRs from forks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be a problem. The token should have enough permissions to add labels, add comments and close PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my curiousity was more around whether a forked pr would have access to secrets. i think it is ok, but wanted to make sure we tried it.
Curious: Does day 1 on the stale check start when this is merged or will issues that have already been inactive for 45 days be marked stale? Also, does triaging actions count as "activity" and would remove stale? Or just comments? The latter is probably preferred IMO. |
i think the time is dictated by the issue's updated_at state (which reflects the last time the issue was updated) against |
Brian is correct (see my earlier reply to Jirka) Brian, for your concern I was planning on adding keep-alive for good first issues before merging. That way those issues are not marked as stale. Also since @kate-goldenring did recent cleanup most issues have been recently updated so we shouldn't see a flood of stales after merge. |
Great idea. Should we expand it to issues that were not triaged yet? Or more generically, have a label to denote issues that await feedback from Akri team? |
Good point, We can also exclude untriaged issues, but right now we don't have any labels for those. |
[SAME VERSION] Workflow to mark inactive issues/PRs as stale and eventually close them Signed-off-by: vincepnguyen <70007233+vincepnguyen@users.noreply.github.com>
What this PR does / why we need it:
Help keeping akri repo current by marking issues and PRs with no recent activity as stale and eventually closing them.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)