-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unix domain socket (uds) gRPC-client implementation compatibility with Googles' C based gRPC (reference) implementation (closes #497) #498
Fix unix domain socket (uds) gRPC-client implementation compatibility with Googles' C based gRPC (reference) implementation (closes #497) #498
Conversation
Signed-off-by: Arne Wendt <arne.wendt@tuhh.de>
Signed-off-by: Arne Wendt <arne.wendt@tuhh.de>
This seems like a great fix to me. I just kicked off the end to end tests. Assuming those pass, I think it is safe assume that going from
@bitmeal what errors are you getting when you run the test? |
|
@bitmeal does it give any extra output? Can you run it with |
Seems to be my fault: Rust toolchain versions have not been set correctly while running tests! I will edit the PR text to reflect the info
Using latest
|
@bitmeal this is a good bump on us. We should put out a new release and bump our rust version soon. |
@bitmeal looks like our tarpaulin workflow is running into the same issue you had and failing: #501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bitmeal!
Thanks to you for the good work! |
… with Googles' C based gRPC (reference) implementation (closes project-akri#497) (project-akri#498) * change uds grpc transport scheme to http:// from dummy:// Signed-off-by: Arne Wendt <arne.wendt@tuhh.de> * bump patch version Signed-off-by: Arne Wendt <arne.wendt@tuhh.de> Signed-off-by: Arne Wendt <arne.wendt@tuhh.de>
What this PR does / why we need it:
closes #497 (at least fixes it)
Special notes for your reviewer:
testdiscovery::server::tests::test_run_discovery_server_error_invalid_ip_addr
is failing (for me) even without the modifications and a clean master branch.If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)