Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained ansi_term dependency #506

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

kate-goldenring
Copy link
Contributor

What this PR does / why we need it:
fixes #502 by bumping webhook's clap version to latest which was previously pulling in the unmaintained dependency

If applicable:

  • version has been updated appropriately (./version.sh)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

…m dep

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@adithyaj
Copy link
Collaborator

adithyaj commented Sep 2, 2022

great simple fix for this issue, looks good to me :shipit:

@kate-goldenring
Copy link
Contributor Author

Looks like in the e2e tests we are failing to spin up a K8s v1.16 cluster. We probably need to change the install script, but better yet, i think it may be time to remove older versions of k8s from the test matrix. This could be part of the release steps. @bfjelds and @adithyaj, thoughts?

@adithyaj
Copy link
Collaborator

adithyaj commented Sep 7, 2022

Looks like in the e2e tests we are failing to spin up a K8s v1.16 cluster. We probably need to change the install script, but better yet, i think it may be time to remove older versions of k8s from the test matrix. This could be part of the release steps. @bfjelds and @adithyaj, thoughts?

Yup this seems to be affecting #508 too. I believe all the kubernetes versions in our test matrix (1.16-1.21) are at EOL. Let's maybe test against the latest EOL version and the rest of the active supported branches (1.21-1.25)? We can also update the release process to check for this.

@michaelzhang114 let's talk about it as a quick agenda item as part of the release for tomorrow's community meeting.

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring
Copy link
Contributor Author

@bfjelds @romoh @Britel can someone tap the approve to get this dep removed?

@adithyaj adithyaj self-requested a review September 19, 2022 17:00
Copy link
Collaborator

@adithyaj adithyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and the version got bumped 0.8.20 so we can merge this now

@kate-goldenring
Copy link
Contributor Author

looks good to me, and the version got bumped 0.8.20 so we can merge this now

we need a maintainer approval to merge. @bfjelds @romoh

@adithyaj adithyaj merged commit c0ddafe into project-akri:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0139: ansi_term is Unmaintained
2 participants