-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unmaintained ansi_term
dependency
#506
Remove unmaintained ansi_term
dependency
#506
Conversation
…m dep Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
great simple fix for this issue, looks good to me |
Yup this seems to be affecting #508 too. I believe all the kubernetes versions in our test matrix (1.16-1.21) are at EOL. Let's maybe test against the latest EOL version and the rest of the active supported branches (1.21-1.25)? We can also update the release process to check for this. @michaelzhang114 let's talk about it as a quick agenda item as part of the release for tomorrow's community meeting. |
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, and the version got bumped 0.8.20 so we can merge this now
What this PR does / why we need it:
fixes #502 by bumping webhook's
clap
version to latest which was previously pulling in the unmaintained dependencyIf applicable:
./version.sh
)