Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong indentation on udev-configuration.yaml for securityContext #538

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Fix wrong indentation on udev-configuration.yaml for securityContext #538

merged 3 commits into from
Dec 1, 2022

Conversation

koutselakismanos
Copy link
Contributor

@koutselakismanos koutselakismanos commented Nov 11, 2022 •
edited
Loading

What this PR does / why we need it:
It fixes the indentation on udev-configuration.yaml for securityContext resulting in null if flag exists.

image

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • [X ] added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@koutselakismanos
fix udev-configuration securityContext indentation
a277733 
Signed-off-by: Koutselakis Manos <koutselakismanos@gmail.com>
@koutselakismanos
Increase version
4b820cf 
Signed-off-by: Koutselakis Manos <koutselakismanos@gmail.com>
kate-goldenring
kate-goldenring approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@koutselakismanos
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Dec 1, 2022
@github-actions
Update patch version
1cc6f84 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring kate-goldenring merged commit 58e3f83 into project-akri:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

Assignees
No one assigned
Labels
version/patch Patch version change is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koutselakismanos @kate-goldenring