Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new K8S versions to tests #545

Merged

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented Dec 21, 2022

What this PR does / why we need it:
Kubernetes released new upstream version (1.26) and all distros were updated to take it into account.
This PR also updates the previous minor versions where applicable.

Special notes for your reviewer:
I've updated also a few things:

  • In 1.26 containerd must be updated as CRI v1alpha2 was removed.
  • Logic for node taints was changed to take into account all next versions of Kubernetes (was quite static in current implementation)

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Jean-Benoit Paux <9682558+jbpaux@users.noreply.github.com>
@kate-goldenring
Copy link
Contributor

@jbpaux can we remove Kubernetes version 1.21 and 1.22 from the test matrix as they have now reached end of life: https://endoflife.date/kubernetes. We are aiming to remove EOL versions each time we add the latest. @adithyaj, would you agree with this?

Signed-off-by: Jean-Benoit Paux <9682558+jbpaux@users.noreply.github.com>
@jbpaux jbpaux force-pushed the features/upgrade-kubernetes-testcases branch from 75810e0 to 59a4efc Compare December 22, 2022 09:14
@jbpaux
Copy link
Contributor Author

jbpaux commented Dec 22, 2022

@kate-goldenring I've removed old Kubernetes versions in latest commit. Should be good.

Signed-off-by: Jean-Benoit Paux <9682558+jbpaux@users.noreply.github.com>
@jbpaux jbpaux force-pushed the features/upgrade-kubernetes-testcases branch from 865b052 to 6db2278 Compare December 22, 2022 09:27
@kate-goldenring
Copy link
Contributor

Thanks @jbpaux for keeping this up to date!

@kate-goldenring kate-goldenring merged commit 47b4258 into project-akri:main Dec 23, 2022
@jbpaux jbpaux deleted the features/upgrade-kubernetes-testcases branch December 24, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants