Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust to 1.68.1 and tarpaulin to 0.25.1 #574

Merged
merged 12 commits into from
Apr 12, 2023

Conversation

harrison-tin
Copy link
Collaborator

@harrison-tin harrison-tin commented Mar 31, 2023

What this PR does / why we need it:

  1. Updates rust toolchain to 1.68.1
  2. Updates Tarpaulin to 0.25.1

Special notes for your reviewer:

  1. New rust version suggests to replace .into_iter().filter().collect() with .retain()
  2. Comments cannot have <> or else it fails cargo doc

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: harrisontin <harrisontin@microsoft.com>
@harrison-tin harrison-tin changed the title update rust to 1.68.2 and tarpaulin to 0.25.1 Update rust to 1.68.2 and tarpaulin to 0.25.1 Mar 31, 2023
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
@harrison-tin harrison-tin changed the title Update rust to 1.68.2 and tarpaulin to 0.25.1 Update rust to 1.68.1 and tarpaulin to 0.25.1 Apr 3, 2023
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the inline docs issue of using <Action> (that is causing the failing Rust Check action) and then LGTM. Also, would be great to follow this up with a PR to akri docs like this one project-akri/akri-docs#41

Signed-off-by: harrisontin <harrisontin@microsoft.com>
@harrison-tin
Copy link
Collaborator Author

Just need to fix the inline docs issue of using <Action> (that is causing the failing Rust Check action) and then LGTM. Also, would be great to follow this up with a PR to akri docs like this one project-akri/akri-docs#41

Thanks! Created a PR to update doc project-akri/akri-docs#65

Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
@yujinkim-msft yujinkim-msft merged commit 0526b9a into project-akri:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants