-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust to 1.68.1 and tarpaulin to 0.25.1 #574
Update rust to 1.68.1 and tarpaulin to 0.25.1 #574
Conversation
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Signed-off-by: harrisontin <harrisontin@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix the inline docs issue of using <Action>
(that is causing the failing Rust Check action) and then LGTM. Also, would be great to follow this up with a PR to akri docs like this one project-akri/akri-docs#41
Signed-off-by: harrisontin <harrisontin@microsoft.com>
Thanks! Created a PR to update doc project-akri/akri-docs#65 |
Signed-off-by: harrisontin <harrisontin@microsoft.com>
b5efaf0
to
9f74274
Compare
Signed-off-by: harrisontin <harrisontin@microsoft.com>
What this PR does / why we need it:
Special notes for your reviewer:
.into_iter().filter().collect()
with.retain()
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)