Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ENTRYPOINT instead of CMD in Dockerfile #631

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented Jul 17, 2023

What this PR does / why we need it:

Closes #239

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Jul 18, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bfjelds
Copy link
Collaborator

bfjelds commented Jul 19, 2023

change looks good, it would be nice to have the tests run on it though.

@diconico07
Copy link
Contributor

change looks good, it would be nice to have the tests run on it though.

About tests runs, I noticed the GitHub action to bump version doesn't re-trigger all tests, but you can still look at the test results of previous commit (with obviously the version test that fails) for that, I didn't find the root cause of tests not running, so that's my workaround

@diconico07 diconico07 merged commit 98b3bd5 into project-akri:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container best practice is to use ENTRYPOINT rather than CMD
3 participants