Add udev e2e tests #637
Merged
Add udev e2e tests #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diconico07
force-pushed
the
add-udev-tests
branch
from
62cbcf4
to
0c9216b
Compare
This commit introduces a new testsuite that ensures the udev Discover Handler is able to discover a basic device, and a grouped device (if any available). Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
diconico07
force-pushed
the
add-udev-tests
branch
from
0c9216b
to
56039b4
Compare
diconico07
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh,
adithyaj and
johnsonshih
as code owners
kate-goldenring
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Thanks @diconico07! Love how this adds a test for a single device and one with many subdevices!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new testsuite that ensures the udev Discover
Handler is able to discover a basic device, and a grouped device (if
any available).
Special notes for your reviewer:
This PR is built on top of #623 only the last commit really belongs to this PR
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)