Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uuids filter to Onvif Discovery Handler #641

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Add uuids filter to Onvif Discovery Handler #641

merged 6 commits into from
Aug 4, 2023

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Aug 1, 2023 •
edited
Loading

What this PR does / why we need it:
ref #636
This PR adds a filter to Onvif Discovery Handler. The new filter compares the device uuid against the Include/Exclude uuid lists to filter devices. The comparison is case-insensitive string comparison.

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@johnsonshih
add uuids filter to Onvif Discovery Handler
966da7b 
Signed-off-by: Johnson Shih <jshih@microsoft.com>
diconico07
diconico07 reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@diconico07 diconico07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just this question over UUID formats

discovery-handlers/onvif/src/discovery_handler.rs Show resolved Hide resolved
@johnsonshih
add uuids filter in helm chart
0a06f13 
Signed-off-by: Johnson Shih <jshih@microsoft.com>
@johnsonshih
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Aug 3, 2023
@github-actions
Update patch version
2e9d2da 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@johnsonshih
Merge branch 'main' into user/jshih/onvif-uuid-filter
994244d 
Signed-off-by: Johnson Shih <jshih@microsoft.com>
@johnsonshih
Merge branch 'main' into user/jshih/onvif-uuid-filter
a074d36 
Signed-off-by: Johnson Shih <jshih@microsoft.com>
@johnsonshih
update patch version
9628d1c 
Signed-off-by: Johnson Shih <jshih@microsoft.com>
@johnsonshih johnsonshih merged commit 18f7dd4 into project-akri:main Aug 4, 2023
50 checks passed
@johnsonshih johnsonshih deleted the user/jshih/onvif-uuid-filter branch August 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diconico07 diconico07 diconico07 approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring kate-goldenring is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

Assignees
No one assigned
Labels
version/patch Patch version change is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsonshih @diconico07