Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace placeholder for initContainers in broker pods #649

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:
Broker pods can have init containers that need access to akri resources.

This commit adds the logic to replace the {{PLACEHOLDER}} for init containers in the same way it is done for regular containers.

Fix #645
Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Broker pods can have init containers that need access to akri resources.

This commit adds the logic to replace the `{{PLACEHOLDER}}` for init
containers in the same way it is done for regular containers.

Fix project-akri#645

Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
@diconico07
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Sep 4, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@diconico07 diconico07 merged commit 834306c into project-akri:main Sep 4, 2023
1 check passed
@diconico07 diconico07 deleted the fix-issue-645 branch September 4, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BrokerPodSpec and initContainers resources PLACEHOLDER
2 participants