chore(rust): update to use rust 1.79 and apply clippy cleanups #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kate-goldenring
commented
Oct 2, 2024
kate-goldenring
commented
- Updates to Rust 1.79
- Updates Cargo.lock files to use workspace level rust version, project version etc.
- Updates version.sh to simplify it thanks to the above
- Applies changes required by latest clippy and fmt
- Allows a few clippy ignores
…e from workspace version Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
requested review from
bfjelds,
jiria,
Britel,
romoh,
adithyaj,
johnsonshih and
diconico07
as code owners
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
rust-1.79
branch
from
3082e50 to
2f25f35
Compare
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
rust-1.79
branch
from
964ea7f to
f301d83
Compare
diconico07
approved these changes
Oct 3, 2024
| @@ -21,3 +21,11 @@ members = [ | |||
| "discovery-handler-modules/udev-discovery-handler", | |||
| ] | |||
| resolver = "2" | |||
|
|
|||
| [workspace.package] | |||
There was a problem hiding this comment.
nit: We may want to also set the authors key here for consistency ?
There was a problem hiding this comment.
I wasn't sure what to put and punted but i think this is worth unifying. I set the global author to be "The Akri Team"
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.