Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: add duplicate envs without instance suffix #710

Merged

Conversation

kate-goldenring
Copy link
Contributor

Adds Configuration broker properties without instance ID

fixes #708

Say a configuration has the following brokerProperties:

  brokerProperties:
    RESOLUTION_WIDTH: "800"
    RESOLUTION_HEIGHT: "600"

Now, the following broker envs are mounted:

RESOLUTION_WIDTH_D46B65="800"
RESOLUTION_HEIGHT_D46B65="600"
RESOLUTION_WIDTH="800"
RESOLUTION_HEIGHT="600"

Ideally, the suffixed envs would not be added (as was the case in the previous release) but to avoid doing so would require the agent to make additional K8s API calls to get the configuration for an configuration-level device plugin which is created by reconciling new instance objects.

Adds duplicate env without instance ID attached

closes #704
Example broker envs for debug echo deployment with these resource requests:
Resource requests:

          requests:
            akri.sh/akri-debug-echo-foo-ab76e6: "1"
            akri.sh/akri-debug-echo-foo-d46b65: "1"

These are the envs mounted in the broker:

DEBUG_ECHO_DESCRIPTION_D46B65=bar0
DEBUG_ECHO_DESCRIPTION_AB76E6=bar1
DEBUG_ECHO_DESCRIPTION=bar1

In this scenario, we discourage people from using DEBUG_ECHO_DESCRIPTION because it is non-deterministic. If one resource request for a Discovery Handler was issued, then DEBUG_ECHO_DESCRIPTION could be consistently used.

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Oct 28, 2024
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring kate-goldenring merged commit ea21796 into project-akri:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
2 participants