fix/feat: add duplicate envs without instance suffix #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Configuration broker properties without instance ID
fixes #708
Say a configuration has the following
brokerProperties
:Now, the following broker envs are mounted:
Ideally, the suffixed envs would not be added (as was the case in the previous release) but to avoid doing so would require the agent to make additional K8s API calls to get the configuration for an configuration-level device plugin which is created by reconciling new instance objects.
Adds duplicate env without instance ID attached
closes #704
Example broker envs for debug echo deployment with these resource requests:
Resource requests:
These are the envs mounted in the broker:
In this scenario, we discourage people from using
DEBUG_ECHO_DESCRIPTION
because it is non-deterministic. If one resource request for a Discovery Handler was issued, thenDEBUG_ECHO_DESCRIPTION
could be consistently used.