Initial Commit of Alvarium Annotator traits package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconn23
reviewed
Jan 12, 2024
There was a problem hiding this comment.
I think this looks good. I think it makes sense to approve this PR first b/c the Rust SDK appears to refer to a DyrellC repo for this dependency. If we approve this then the SDK PR can be updated to refer to this module.
If you agree about my other comment w/r/t the edition value in the Cargo.toml then please make that change. That's the only thing I would suggest, otherwise this looks good.
tsconn23
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the base package for the rust sdk functionality. It provides the reusable constants and flexible type definitions to allow for custom annotator libraries to be developed with flexible interoperability.