fix for show process not working #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvasanthm
reviewed
Sep 11, 2019
arunsundark
force-pushed
the
sys-pfm-cli-bug-fix
branch
from
c0b4b26 to
7d9db0f
Compare
rvasanthm
approved these changes
Sep 11, 2019
seiferteric
added a commit
that referenced
this pull request
Mar 24, 2020
* [JIRA SONIC-9259] Add range limit to mtu in sonic-port. Change-Id: I5917eb03c44410fcf0aa0ceb5720cd5c12415d00 * Signature chnage for transformer functions * modified acl-key xfmr to return integer and enhanced the get-req handling in common app. * make common-app as default to handle acl, add the field-xfmr for acl type * [JIRA SONIC-9203] Added IP_TYPE field with value ANY in DEFAULT_RULE. Change-Id: I82ec0a1610da009f9906d0ac2ab7c5eb5aa4b13b * Fix for bugs 96, 97 and 107 * Addressed the comment to sort the speed * Fix sonic get query failure * fix to exclude key-leaf data populating db-filed value and removed commented lines in xmfr_acl * Change MAX_MTU to 9216 in platform_dummy file as well, since it overwrites it. * Fix for bugs 96, 97 and 107 (Speed is not displaying properly) (#109) * Fix for not showing description when description is configured as part of #show interface command. * Addressing the crash when max mtu is set as 9276. Currently supported max-mtu is 9216. * Fix for bugs 96, 97 and 107 * Addressed the comment to sort the speed * Change MAX_MTU to 9216 in platform_dummy file as well, since it overwrites it. * fix for show process not working (#110) * added unit8 yang data0type support for get-req * Fix crash for get leaf query * cleanup code to showcase overloaded methods * [JIRA SONIC-9466] merge mgmt-framework bug fixes from Dell - 12th Sept Change-Id: I2a92251040a816c24f8433e49dd508091dbb494b * fix the build error * Fis get leaf crash, remove unsed annotations * [JIRA SONIC-9426] CVL throws error when trying to configure IP address. Change-Id: Iec675bff98c912ef5d80a2d38524748d6a0b1683 * [JIRA SONIC-9494] CVL Error seen when performing no description on interface Change-Id: Ic3e89d74bd399e891a06e14bd4ff7dcd486a9090 * [JIRA SONIC-9420] Updated Help string to display max length of ACL is 63 characters. Added pattern and length check in CVL yang also to allow 72 characters (63 of acl name + 9 from acl type ex. _ACL_IPV4) Change-Id: Iba9ffc7aa34f1600c61b95ec9a3e23971533e829 * [JIRA SONIC-9496] Disabled nonyang demo app Disabled nonyang vlan demo app by adding .demo suffix to yaml and app module code. It can bemanually enabled by renaming those files back. Change-Id: I1714e772fb452ae246d44af65d43dd1cf65f5e18 * Adding Interface table entry with just name, before the one with ifname and IP. * add get-validate to validate a YANG node durin data translation back to YANG response * Fix crash during update request to leaflist * Fix top level delete * Fix: Incorrect LLDP neighbor TTL (#117) * Remove the TTL information from CLI and GNMI output because LLDP neighbor TTL information is currently not stored in appDB. Signed-off-by: Garrick He <garrick_he@dell.com> * Bugfix for creating 2 interface entries when IP is configured, and when interface comes up as L2. (#116) * [JIRA SONIC-9314] Modified the MAX_PRIORITY constant to 65536, to help app module to translate between SeqId and priority when given max seqid of 65535. Change-Id: I314e5cabb89779e0410d05d18152425f2c0228b2 * [JIRA SONIC-9472] Modified logic in Jinja template for "show ip access-group" to display both Ingress and Egress ACLs for single port. Also updated help message for max allowed characters for acl name in "show" commands. sonic# show ip access-group Ingress IP access-list A1 on Ethernet0 Egress IP access-list A2 on Ethernet0 Ingress IP access-list A1 on Ethernet4 Egress IP access-list A2 on Ethernet4 sonic# Change-Id: I601e1b21b01e40ea6a285400e803092c66f1c941 * [JIRA SONIC-9521] Merge mgmt-framework changes by Dell team - 13th Sep Change-Id: I2a830e2198b506525ae970377a5bbfb49a98006b * [JIRA SONIC-9486] Permit only TLS1.2 or higher in REST Server Management REST Server is enhanced to use only TLS1.2 or higer version with one of below cipher suites (in order). TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 Similar changes to gNMI telemetry server will be done by Dell team. UT: 1) Verified ACL CLIs, which also verifies client SDK 2) Verified swagger UI with Chrome and Firefox browsers 3) Verified thru curl that sslv2, sslv3, tlsv1.0, tlsv1.1 clients are rejected by REST Server. 4) Verified thru curl that unsupported ciphers TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA and TLS_RSA_WITH_3DES_EDE_CBC_SHA are rejected by REST Server. 5) Mgmt-framework automated UT Change-Id: I378522335f69d9a73ff7d62dc7ceec79087faf2f * added yang annotations * Get case - leaf-list support in Transformer core for Sonic and OC yang. * add the field transformer for forwarding-action * Set case - leaf-list support in transformer core for OC yang * provision to get data for sibling container from the module level * Fixed variable scope issue while processing leaf data to redis DB format * fix license header * Updated license statement for REST server sources * Update license header * update broadcom license for pyang plugin for openAPI * Updated License statement * Update broadcom license * DB Access Layer: Update Broadcom License * Add validate callback function support for acl. Children will inherit parent validate handler * Add copyright/license headers (#123) Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com> * move json creation for sonic-yang to map * Moving unwanted CVL YANG to testdata * Updated Makefiles * Delete file checked in mistakenly. * Updated new Makefile with license, copy schema from testdata/schema also. * Updated License statement * Update License statement * update broadcom license and made changes to keep the diff file in the ygot-modified directory * error handling and code clean-up * update broadcom license to the diff files which are created for patching ygot files * Add error handling in xlate_utils.go * fix the uint64 encoding, fix the ygot bug in handling the union type of leafref * For a Get req on individual terminal node- Fix overloaded function processing, data-type conversion and leaf-list check handling * table transformer support * CLI skeletion for VLAN feature: config, show and its templates * Made changes to keep the patch files into single patch file * Cleanup of unused code * Updated the ygot patch file * Changes for supporting show command with dummy data * add the union type * Update Makefile Add rule to compile test YANG schema * CLI skeleton for Port channel Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com> * Add post transformer infra * CVL changes for SONiC YANG * CVL changes for SONiC YANG * Initial support for table transformer * Fix issues in initial commit for table transformer * copy the misisng lines from transformer-phase1 * add missing lines from transforer-phase1 * support for table transformer for crud and get operation * Extend annotations for augmentations in oc-yang * Addressing the comments mentioned * Fixed alignment of XML files * Cleanup of the xml files * Handle nested groupings for augmentation * changed the xSpecMap to xYangSpecMap for code clarity and added new file with transformer-constants * Changes to remove dummy json file Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com> * Enhanced transformer core to support user-defined key-delimiter/concatenater * basic support for sonic-yang annotation * Fill cvl KeySpec with DbName read from annotation * More changes for CVL YANG * Fix table get in Traverse for App DB with ":" separator * added support to invoke container level key transformer * added code to pass the current ygot node to the key xfmr function * added support for sonic yang non-config db get request * Data base specific key-delimiter support in transformer core - Sonic Get case * Changes in show port-channel command Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com> * Add checks for xpath entry in xYangSpecMap and xDbSpecMap * Chk for list type to create keySpec * workaround for VLAN_MEMBER_TABLE list level get due to translib.generateGetResponsePayload() failure * added key-name support for oc yang and support to create and push table with just the keys and no field-value data in to redis. * Updated Makefile * OC Yang Get case - DB type based key-delimiter support in transformer core * CVl changes for SONiC YANG * CVL changes for SONiC YANG * Add check for no xfmrFunc defined case * Correct naming convention for Interface commands Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com> * Changed processLeafList() function name to checkAndProcessLeafList() , added comments and removed unnecessary logs in common app * fix for vlan get-req crash * sonic yang get case handling for table instance level * Handle nested db-name annotations for oc * Import module name of the annotated module in annotate template file * Added table transformer method prototype. * Added table transformer extension * Include the prefix for the module where the grouping is used in annotation template * Include unique namespace, Use the prefix of the including module * xspec map and cru support in transformer infra per revised sonic-yang and changed the api-names from cvl to sonic * Management interface cli tree, actioner implementation and sonic yang for management port and interface config handling. (#153) * sFlow CLI Template (#147) * sFlow CLI template * Add XML skeleton for the sFlow CLI * Add actioner script * Add renderer template Signed-off-by: Garrick He <garrick_he@dell.com> * added code to support reading db data for get req per revised sonic-yang * rearranged the code to call the table transformer and collect data before calling the subtree-transformer overloaded method. * Fixed table transformer GET case issues : 1.) calling table-transformer for each leaf when doing a get on parent conatiner(OC-interface) 2.) dbMapData not getting filled for container query in dbDataToYangJsonCreate * Handle delete for restructured sonic yang * Strip augmented module names in xpath to reference xYangSpecMap * transformer infra support for revised sonic-yang GET req * Handle delete for restructured sonic acl * Fix the leaf level get for restructured sonic yang * Make file changes to generate sonic yaml files * support table transformer - GET case on leaf or nested container * Get for sonic yang at instance level to return single instance data * Use new xpathPredicate function that removes augmented module name in the uri * Bug fixed for not showing GB instead of Gx * Add Copyright info * Sonic yang restructuring fix terminal node leaf/leaf-list cases * revert accidently added local changes in xspec.go * Clean up of files and add missed items during merge * exclude annotation file from generating ocbinds * fix Makefile in installing yang files from cv/schema * add back the cv/schema/*yin * Fixed list instance level GET issue * Revert "Merge pull request #173 from project-arlo/transformer-phase2" This reverts commit ca4b330, reversing changes made to 211f17e. * Revert "Merge branch 'transformer-phase1' into transformer_merge" This reverts commit 211f17e, reversing changes made to f032ec5. * commit Transformer codes for community PR * Update Makefile * Update Makefile * undo ygot patch changes done by kwan * update the patch file * Patch goyang files to make rules * Add missing models list file * Remove network-instance yang * Addressing PR review comments. * Add new file entry in goyang.patch file * Incorporating review comments - phase2 * Adding comment for TRACE_ONERROR * Moving go-server.sh to tools/test/rest-server.sh * Correcting regex pattern for key names * Correct error code if key does not exist * Address review comments * Address review comments * Address PR review comments - phase2 * Add validation for speed and description (#291) * Add validation for speed and description * Add pattern for alias * Updated the Makefile to have go pkg version, and renamed the ACL CLI actioner file * Update control * Moving jsonquery patch in patches/jsonquery.patch file, updating testcases as per latest YANG model. * Minor change in test case. * Updating makefile * Checkout jsonquery only once. * Use git clean before patching to ensure no files are left behind Co-authored-by: asha-behera <51354864+asha-behera@users.noreply.github.com> Co-authored-by: ranjinidn <51423501+ranjinidn@users.noreply.github.com> Co-authored-by: s-mari <52256418+s-mari@users.noreply.github.com> Co-authored-by: Kwan <kwangsuk_kim@dell.com> Co-authored-by: Mayank Maheshwari <51356673+maheshwari-mayank@users.noreply.github.com> Co-authored-by: Justine Jose <51496803+justinejose91@users.noreply.github.com> Co-authored-by: Arunsundar Kannan <31632515+arunsundark@users.noreply.github.com> Co-authored-by: Kwan Kim <29056019+redfish-api@users.noreply.github.com> Co-authored-by: Sachin Holla <51310506+sachinholla@users.noreply.github.com> Co-authored-by: Garrick He <32883830+GarrickHe@users.noreply.github.com> Co-authored-by: Partha Dutta <51353699+dutta-partha@users.noreply.github.com> Co-authored-by: amrutasali <51424374+amrutasali@users.noreply.github.com> Co-authored-by: Faraaz mohammed <faraazc@gmail.com> Co-authored-by: anand-kumar-subramanian <51383315+anand-kumar-subramanian@users.noreply.github.com> Co-authored-by: a-barboza <29963827+a-barboza@users.noreply.github.com> Co-authored-by: Tejaswi Goel <Tejaswi_Goel@Dell.com> Co-authored-by: Balachandar Mani <balachandar.mani@broadcom.com> Co-authored-by: rvasanthm <51932293+rvasanthm@users.noreply.github.com> Co-authored-by: joyas-joseph <51463120+joyas-joseph@users.noreply.github.com> Co-authored-by: Eric Seifert <seiferteric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show CLI after the fix