Make all TH dependencies not static #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
hiltonlima
approved these changes
Oct 31, 2024
|
Maybe we should create a new branch, like: |
antonio-amjr
approved these changes
Oct 31, 2024
rquidute
changed the title
ccruzagralopes
approved these changes
Oct 31, 2024
raju-apple
approved these changes
Nov 1, 2024
I leave it to the group, but the CCB should be handled beforehand (noting it was not discussed in the last CSG call), and making this a new branch will mean that for this minor change members will need to pick up on it. As long as the CCB is approved, merging against the original branch in this minor case might be OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
The goal of this PR is avoid keeping all TH dependencies static since the version might no longer be available
Related Issue
#479