Fix minimal mDNS ResolvedNodeData::mAddress overflow (#12672)

project-chip · Dec 5, 2023 · 1320888 · 1320888
1 parent ed947f5
commit 1320888
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/lib/dnssd/Resolver_ImplMinimalMdns.cpp b/src/lib/dnssd/Resolver_ImplMinimalMdns.cpp
@@ -178,6 +178,10 @@ void PacketDataReporter::OnOperationalIPAddress(const chip::Inet::IPAddress & ad
  // This code assumes that all entries in the mDNS packet relate to the
  // same entity. This may not be correct if multiple servers are reported
  // (if multi-admin decides to use unique ports for every ecosystem).
+ if (mNodeData.mNumIPs >= ResolvedNodeData::kMaxIPAddresses)
+ {
+ return;
+ }
  mNodeData.mAddress[mNodeData.mNumIPs++] = addr;
  mNodeData.mInterfaceId = mInterfaceId;
  mHasIP = true;