Skip to content

Commit

Permalink
[nrfconnect] Fixed using Kconfig.features options (#17313)
Browse files Browse the repository at this point in the history
Kconfig.features is currently sourced after Kconfig.defaults,
so the default values from Kconfig.defaults are used and features
cannot modify it.

Removed Kconfig.features to be sourced before Kconfig.defaults.
  • Loading branch information
kkasperczyk-no authored and pull[bot] committed Jun 26, 2023
1 parent 5e88c2a commit 1484540
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion examples/all-clusters-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ config STATE_LEDS
Use LEDs to render the current state of the device such as the progress of commissioning of
the device into a network or the factory reset initiation.

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/light-switch-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ config STATE_LEDS
the device into a network or the factory reset initiation. Note that setting this option to
'n' does not disable the LED indicating the state of the simulated bolt.

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/lighting-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
#
mainmenu "Matter nRF Connect Lighting Example Application"

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/lock-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ config STATE_LEDS
the device into a network or the factory reset initiation. Note that setting this option to
'n' does not disable the LED indicating the state of the simulated bolt.

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/pigweed-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
#
mainmenu "Matter nRF Connect Lighting Example Application"

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/pump-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
#
mainmenu "Matter nRF Connect Lighting Example Application"

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/pump-controller-app/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
#
mainmenu "Matter nRF Connect Lighting Example Application"

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"
2 changes: 1 addition & 1 deletion examples/shell/nrfconnect/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
#
mainmenu "Matter nRF Connect Lighting Example Application"

rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
rsource "../../../config/nrfconnect/chip-module/Kconfig.features"
rsource "../../../config/nrfconnect/chip-module/Kconfig.defaults"
source "Kconfig.zephyr"

0 comments on commit 1484540

Please sign in to comment.