Move GetAttestationChallenge() implementation to DeviceProxy.cpp (#19058

) Followup from #18867 (comment)
project-chip · Aug 1, 2023 · 1756201 · 1756201
1 parent ce447f0
commit 1756201
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/app/DeviceProxy.cpp b/src/app/DeviceProxy.cpp
@@ -46,4 +46,15 @@ CHIP_ERROR DeviceProxy::SendCommands(app::CommandSender * commandObj, Optional<S
  return commandObj->SendCommandRequest(GetSecureSession().Value(), timeout);
 }
 
+CHIP_ERROR DeviceProxy::GetAttestationChallenge(ByteSpan & attestationChallenge)
+{
+ Optional<SessionHandle> secureSessionHandle;
+
+ secureSessionHandle = GetSecureSession();
+ VerifyOrReturnError(secureSessionHandle.HasValue(), CHIP_ERROR_INCORRECT_STATE);
+
+ attestationChallenge = secureSessionHandle.Value()->AsSecureSession()->GetCryptoContext().GetAttestationChallenge();
+ return CHIP_NO_ERROR;
+}
+
 } // namespace chip
diff --git a/src/app/DeviceProxy.h b/src/app/DeviceProxy.h
@@ -67,16 +67,7 @@ class DLL_EXPORT DeviceProxy
  *
  * @return CHIP_ERROR CHIP_NO_ERROR on success, or CHIP_ERROR_INVALID_ARGUMENT if no secure session is active
  */
- virtual CHIP_ERROR GetAttestationChallenge(ByteSpan & attestationChallenge)
- {
- Optional<SessionHandle> secureSessionHandle;
-
- secureSessionHandle = GetSecureSession();
- VerifyOrReturnError(secureSessionHandle.HasValue(), CHIP_ERROR_INCORRECT_STATE);
-
- attestationChallenge = secureSessionHandle.Value()->AsSecureSession()->GetCryptoContext().GetAttestationChallenge();
- return CHIP_NO_ERROR;
- }
+ virtual CHIP_ERROR GetAttestationChallenge(ByteSpan & attestationChallenge);
 
 protected:
  virtual bool IsSecureConnected() const = 0;