address comment

project-chip · Sep 5, 2023 · 19db342 · 19db342
1 parent 080ee5b
commit 19db342
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 5 deletions.
diff --git a/scripts/tools/check_includes_config.py b/scripts/tools/check_includes_config.py
@@ -162,5 +162,6 @@
  # Not intended for embedded clients
  'src/lib/support/jsontlv/JsonToTlv.cpp': {'sstream'},
  'src/lib/support/jsontlv/JsonToTlv.h': {'string'},
- 'src/lib/support/jsontlv/TlvToJson.h': {'string'}
+ 'src/lib/support/jsontlv/TlvToJson.h': {'string'},
+ 'src/lib/support/jsontlv/TextFormat.h': {'string'}
 }
diff --git a/src/lib/support/jsontlv/BUILD.gn b/src/lib/support/jsontlv/BUILD.gn
@@ -28,7 +28,7 @@ static_library("jsontlv") {
 
  public = [
  "JsonToTlv.h",
- "JsonUtilities.h",
+ "TextFormat.h",
  "TlvJson.h",
  "TlvToJson.h",
  ]

diff --git a/src/lib/support/jsontlv/JsonUtilities.h → src/lib/support/jsontlv/TextFormat.h b/src/lib/support/jsontlv/JsonUtilities.h → src/lib/support/jsontlv/TextFormat.h
@@ -19,6 +19,7 @@
 #include <algorithm>
 #include <json/json.h>
 #include <lib/core/TLV.h>
+#include <string>
 
 namespace chip {
 /*

diff --git a/src/lib/support/tests/TestJsonToTlv.cpp b/src/lib/support/tests/TestJsonToTlv.cpp
@@ -22,7 +22,7 @@
 #include <lib/core/TLVReader.h>
 #include <lib/support/UnitTestRegistration.h>
 #include <lib/support/jsontlv/JsonToTlv.h>
-#include <lib/support/jsontlv/JsonUtilities.h>
+#include <lib/support/jsontlv/TextFormat.h>
 #include <lib/support/jsontlv/TlvToJson.h>
 #include <nlunit-test.h>
 

diff --git a/src/lib/support/tests/TestJsonToTlvToJson.cpp b/src/lib/support/tests/TestJsonToTlvToJson.cpp
@@ -20,7 +20,7 @@
 #include <app/data-model/Encode.h>
 #include <lib/support/UnitTestRegistration.h>
 #include <lib/support/jsontlv/JsonToTlv.h>
-#include <lib/support/jsontlv/JsonUtilities.h>
+#include <lib/support/jsontlv/TextFormat.h>
 #include <lib/support/jsontlv/TlvToJson.h>
 #include <nlunit-test.h>
 

diff --git a/src/lib/support/tests/TestTlvToJson.cpp b/src/lib/support/tests/TestTlvToJson.cpp
@@ -19,7 +19,7 @@
 #include <app/data-model/Decode.h>
 #include <app/data-model/Encode.h>
 #include <lib/support/UnitTestRegistration.h>
-#include <lib/support/jsontlv/JsonUtilities.h>
+#include <lib/support/jsontlv/TextFormat.h>
 #include <lib/support/jsontlv/TlvToJson.h>
 #include <nlunit-test.h>
 #include <system/SystemPacketBuffer.h>