[Ameba] Upgrade cpp17 (#28438)

* fix cmake workaround for ameba
- upgrade pigweed app to c++17

* Update Dockerfile

* Update version

* Move to chip-build-ameba version 4 instead of 1, to suppor c++17

---------

Co-authored-by: Andrei Litvin <andy314@gmail.com>
Co-authored-by: Andrei Litvin <andreilitvin@google.com>

.github/workflows/examples-ameba.yaml

@@ -36,7 +36,7 @@ jobs:
  if: github.actor != 'restyled-io[bot]'
 
  container:
- image: ghcr.io/project-chip/chip-build-ameba:1
+ image: ghcr.io/project-chip/chip-build-ameba:4
  options: --user root
 
  steps:

examples/all-clusters-app/ameba/README.md

@@ -27,11 +27,11 @@ The CHIP demo application is supported on
 
 - Pull docker image:
 
-  $ docker pull ghcr.io/project-chip/chip-build-ameba:1
+  $ docker pull ghcr.io/project-chip/chip-build-ameba:4
 
 - Run docker container:
 
-  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:1
+  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:4
 
 - Setup build environment:
 

examples/all-clusters-minimal-app/ameba/README.md

@@ -27,13 +27,13 @@ The CHIP demo application is supported on
 - Pull docker image:
 
   ```
-  $ docker pull ghcr.io/project-chip/chip-build-ameba:1
+  $ docker pull ghcr.io/project-chip/chip-build-ameba:4
   ```
 
 - Run docker container:
 
   ```
-  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:1
+  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:4
   ```
 
 - Setup build environment:

examples/light-switch-app/ameba/README.md

@@ -26,11 +26,11 @@ The CHIP demo application is supported on
 
 - Pull docker image:
 
-  $ docker pull ghcr.io/project-chip/chip-build-ameba:1
+  $ docker pull ghcr.io/project-chip/chip-build-ameba:4
 
 - Run docker container:
 
-  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:1
+  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:4
 
 - Setup build environment:
 

examples/lighting-app/ameba/README.md

@@ -23,11 +23,11 @@ The CHIP demo application is supported on
 
 - Pull docker image:
 
-  $ docker pull ghcr.io/project-chip/chip-build-ameba:1
+  $ docker pull ghcr.io/project-chip/chip-build-ameba:4
 
 - Run docker container:
 
-  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:1
+  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:4
 
 - Setup build environment:
 

examples/ota-requestor-app/ameba/README.md

@@ -6,11 +6,11 @@ A prototype application that demonstrates OTA Requestor capabilities.
 
 - Pull docker image:
 
-  $ docker pull ghcr.io/project-chip/chip-build-ameba:1
+  $ docker pull ghcr.io/project-chip/chip-build-ameba:4
 
 - Run docker container:
 
-  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:1
+  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:4
 
 - Setup build environment:
 

examples/pigweed-app/ameba/README.md

@@ -31,11 +31,11 @@ following features are available:
 
 - Pull docker image:
 
-  $ docker pull ghcr.io/project-chip/chip-build-ameba:1
+  $ docker pull ghcr.io/project-chip/chip-build-ameba:4
 
 - Run docker container:
 
-  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:1
+  $ docker run -it -v ${CHIP_DIR}:/root/chip ghcr.io/project-chip/chip-build-ameba:4
 
 - Setup build environment:
 

examples/pigweed-app/ameba/chip_main.cmake

@@ -100,9 +100,9 @@ list(
  APPEND chip_main_cpp_flags
 
  -Wno-unused-parameter
- -std=gnu++17
+ -std=c++17
  -fno-rtti
- -fno-use-cxa-atexit
+  -fno-use-cxa-atexit
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
 target_compile_options(${chip_main} PRIVATE ${chip_main_cpp_flags})

src/app/chip_data_model.cmake

@@ -16,13 +16,6 @@
 
 set(CHIP_APP_BASE_DIR ${CMAKE_CURRENT_LIST_DIR})
 
-if (NOT CHIP_ROOT)
- # TODO: these are WORKAROUNDS and should be removed
- if(DEFINED ameba_matter_root)
- SET(CHIP_ROOT "${ameba_matter_root}")
- endif()
-endif()
-
 include("${CHIP_ROOT}/build/chip/chip_codegen.cmake")
 
 # Configure ${APP_TARGET} with source files associated with ${CLUSTER} cluster