Mark event paths as urgent when doing node-wide subscriptions in Matt…

…er.framework. (#23226) Otherwise we will not receive events until the max-interval elapses.
project-chip · Jan 19, 2023 · 2614370 · 2614370
1 parent 09a9456
commit 2614370
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/darwin/Framework/CHIP/MTRBaseDevice.mm b/src/darwin/Framework/CHIP/MTRBaseDevice.mm
@@ -294,6 +294,8 @@ - (void)subscribeWithQueue:(dispatch_queue_t)queue
  // Wildcard endpoint, cluster, attribute, event.
  auto attributePath = std::make_unique<AttributePathParams>();
  auto eventPath = std::make_unique<EventPathParams>();
+ // We want to get event reports at the minInterval, not the maxInterval.
+ eventPath->mIsUrgentEvent = true;
  ReadPrepareParams readParams(session.Value());
  readParams.mMinIntervalFloorSeconds = minInterval;
  readParams.mMaxIntervalCeilingSeconds = maxInterval;

diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -299,6 +299,8 @@ - (void)subscribeWithMinInterval:(uint16_t)minInterval maxInterval:(uint16_t)max
  // Wildcard endpoint, cluster, attribute, event.
  auto attributePath = std::make_unique<AttributePathParams>();
  auto eventPath = std::make_unique<EventPathParams>();
+ // We want to get event reports at the minInterval, not the maxInterval.
+ eventPath->mIsUrgentEvent = true;
  ReadPrepareParams readParams(session.Value());
  readParams.mMinIntervalFloorSeconds = minInterval;
  readParams.mMaxIntervalCeilingSeconds = maxInterval;