Skip to content

Commit

Permalink
Add GetCommissionerNodeId to chip-reply yamltest runner (#24793)
Browse files Browse the repository at this point in the history
  • Loading branch information
tehampson authored and pull[bot] committed Oct 26, 2023
1 parent 3f1bc65 commit 3350073
Showing 1 changed file with 22 additions and 8 deletions.
30 changes: 22 additions & 8 deletions src/controller/python/chip/yaml/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ class _TestFabricId(IntEnum):
GAMMA = 3


@dataclass
class _GetCommissionerNodeIdResult:
node_id: int


@dataclass
class _ActionResult:
status: _ActionStatus
Expand Down Expand Up @@ -487,17 +492,23 @@ def __init__(self, test_step):
UnexpectedParsingError: Raised if the expected queue does not exist.
'''
super().__init__(test_step)
if test_step.command != 'PairWithCode':
self._command = test_step.command
if test_step.command == 'GetCommissionerNodeId':
# Just setting the self._command is enough for run_action below.
pass
elif test_step.command == 'PairWithCode':
args = test_step.arguments['values']
request_data_as_dict = Converter.convert_list_of_name_value_pair_to_dict(args)
self._setup_payload = request_data_as_dict['payload']
self._node_id = request_data_as_dict['nodeId']
else:
raise UnexpectedParsingError(f'Unexpected CommisionerCommand {test_step.command}')

args = test_step.arguments['values']
request_data_as_dict = Converter.convert_list_of_name_value_pair_to_dict(args)
self._setup_payload = request_data_as_dict['payload']
self._node_id = request_data_as_dict['nodeId']

def run_action(self, dev_ctrl: ChipDeviceController) -> _ActionResult:
resp = dev_ctrl.CommissionWithCode(self._setup_payload, self._node_id)
if self._command == 'GetCommissionerNodeId':
return _ActionResult(status=_ActionStatus.SUCCESS, response=_GetCommissionerNodeIdResult(dev_ctrl.nodeId))

resp = dev_ctrl.CommissionWithCode(self._setup_payload, self._node_id)
if resp:
return _ActionResult(status=_ActionStatus.SUCCESS, response=None)
else:
Expand Down Expand Up @@ -738,6 +749,10 @@ def decode(self, result: _ActionResult):
decoded_response['error'] = stringcase.snakecase(response.name).upper()
return decoded_response

if isinstance(response, _GetCommissionerNodeIdResult):
decoded_response['value'] = {'nodeId': response.node_id}
return decoded_response

if isinstance(response, chip.discovery.CommissionableNode):
# CommissionableNode(
# instanceName='04DD55352DD2AC53',
Expand Down Expand Up @@ -780,7 +795,6 @@ def decode(self, result: _ActionResult):
'numIPs': len(response.addresses),

}

return decoded_response

if isinstance(response, ChipStackError):
Expand Down

0 comments on commit 3350073

Please sign in to comment.