Add bloat check steps for all examples

project-chip · Jun 3, 2020 · 3688738 · 3688738
1 parent 0b3c4d5
commit 3688738
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 29 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
diff --git a/.circleci/config/jobs/examples_esp32.yml b/.circleci/config/jobs/examples_esp32.yml
@@ -18,6 +18,9 @@ steps:
  scripts/helpers/bloat-check.sh \
  'Build Examples [ESP32]' \
  example_binaries/esp32-build \
- master_binaries/esp32-build
+ master_binaries/esp32-build \
+ bloat_report.txt
  - store_artifacts:
  path: example_binaries/esp32-build
+ - store_artifacts:
+ path: bloat_report.txt
diff --git a/.circleci/config/jobs/examples_nrf.yml b/.circleci/config/jobs/examples_nrf.yml
@@ -12,5 +12,15 @@ steps:
  mkdir -p example_binaries/nrf-build
  cp examples/lock-app/nrf5/build/chip-nrf52840-lock-example.out \
  example_binaries/nrf-build/chip-nrf52840-lock-example.out
+ - run:
+ name: Bloat check
+ command: |
+ scripts/helpers/bloat-check.sh \
+ 'Build Examples [nRF]' \
+ example_binaries/esp32-build \
+ master_binaries/esp32-build \
+ bloat_report.txt
  - store_artifacts:
  path: example_binaries/nrf-build
+ - store_artifacts:
+ path: bloat_report.txt
diff --git a/.circleci/config/jobs/examples_standalone.yml b/.circleci/config/jobs/examples_standalone.yml
@@ -1,26 +1,36 @@
 parameters:
- builder:
- type: string
+  builder:
+  type: string
 environment:
- BUILD_TYPE: "<< parameters.builder >>"
+  BUILD_TYPE: "<< parameters.builder >>"
 executor: << parameters.builder >>
 steps:
- - load-built-tree:
- builder: << parameters.builder >>
- - load-build-environment:
- builder: << parameters.builder >>
- - load-persistent-ci-cache:
- builder: << parameters.builder >>
- - setup-environment:
- builder: << parameters.builder >>
- - run:
- name: Build example Standalone Echo Client
- command: scripts/examples/standalone_echo_client.sh
- - run:
- name: Preserve artifacts
- command: |
- mkdir -p example_binaries/<<parameters.builder>>
- cp examples/chip-tool/build/chip-standalone-demo.out \
- example_binaries/<<parameters.builder>>/chip-standalone-demo.out
- - store_artifacts:
- path: example_binaries/<<parameters.builder>>
+ - load-built-tree:
+ builder: << parameters.builder >>
+ - load-build-environment:
+ builder: << parameters.builder >>
+ - load-persistent-ci-cache:
+ builder: << parameters.builder >>
+ - setup-environment:
+ builder: << parameters.builder >>
+ - run:
+ name: Build example Standalone Echo Client
+ command: scripts/examples/standalone_echo_client.sh
+ - run:
+ name: Preserve artifacts
+ command: |
+ mkdir -p example_binaries/<<parameters.builder>>
+ cp examples/chip-tool/build/chip-standalone-demo.out \
+ example_binaries/<<parameters.builder>>/chip-standalone-demo.out
+ - run:
+ name: Bloat check
+ command: |
+ scripts/helpers/bloat-check.sh \
+ 'Build Examples [<< parameters.builder >>]' \
+ example_binaries/<<parameters.builder>> \
+ master_binaries/<<parameters.builder>> \
+ bloat_report.txt
+ - store_artifacts:
+ path: example_binaries/<<parameters.builder>>
+ - store_artifacts:
+ path: bloat_report.txt
diff --git a/scripts/helpers/bloat-check.sh b/scripts/helpers/bloat-check.sh
@@ -5,18 +5,18 @@ set -x
 JOBNAME=$1
 SOURCEDIR=$2
 OUTPUTDIR=$3
+REPORTFILE=$4
 
 mkdir -p ${OUTPUTDIR}
 scripts/helpers/ci-fetch-artifacts.py \
  --token "${CIRCLECI_API_TOKEN}" \
  --job "${JOBNAME}" \
  --download-dir "${OUTPUTDIR}"
 
+echo "BLOAT REPORT" >${REPORTFILE}
+
 for masterbinary in ${OUTPUTDIR}/*; do
  newbinary=${SOURCEDIR}/$(basename $masterbinary)
- echo "Checking $newbinary against $masterbinary"
- echo "Size difference:"
- bloaty $newbinary -- $masterbinary
- echo "Largest symbols information:"
- bloaty -d symbols -C short $newbinary | head -n 20
+ echo "Checking $newbinary against $masterbinary" >${REPORTFILE}
+ bloaty $newbinary -- $masterbinary >${REPORTFILE}
 done